Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forum heading and followAfterReply #57

Merged
merged 2 commits into from
Dec 27, 2015

Conversation

petermein
Copy link
Contributor

No description provided.

@franzliedke
Copy link
Contributor

If I'm not mistaken, the keys do not match up with the ones in flarum/subscriptions#6.

@petermein
Copy link
Contributor Author

Correct, i changed the path to match the files.

franzliedke added a commit that referenced this pull request Dec 27, 2015
Added forum heading and followAfterReply
@franzliedke franzliedke merged commit 4d090eb into flarum:master Dec 27, 2015
@tobyzerner
Copy link
Contributor

Not sure this should've been merged until after flarum/subscriptions#6 has been... I made a suggestion in flarum/framework#310 (comment) to put the switch under the "notifications" fieldset which would make the forum_heading translation unused, but it hasn't been implemented yet. Oh well, we'll get there :P

@franzliedke
Copy link
Contributor

Sorry about this. :(

askvortsov1 pushed a commit that referenced this pull request Mar 11, 2022
Added forum heading and followAfterReply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants