Fixes ethereum#60

fjl · May 28, 2014 · b695c82 · b695c82
1 parent a98e35d
commit b695c82
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/ethchain/state_manager.go b/ethchain/state_manager.go
@@ -105,8 +105,11 @@ func (sm *StateManager) ApplyTransactions(state *State, block *Block, txs []*Tra
 	for _, tx := range txs {
 		usedGas, err := sm.ApplyTransaction(state, block, tx)
 		if err != nil {
+			if IsNonceErr(err) {
+				continue
+			}
+
 			ethutil.Config.Log.Infoln(err)
-			//continue
 		}
 
 		accumelative := new(big.Int).Set(totalUsedGas.Add(totalUsedGas, usedGas))
@@ -116,7 +119,7 @@ func (sm *StateManager) ApplyTransactions(state *State, block *Block, txs []*Tra
 		validTxs = append(validTxs, tx)
 	}
 
-	return receipts, txs
+	return receipts, validTxs
 }
 
 func (sm *StateManager) ApplyTransaction(state *State, block *Block, tx *Transaction) (totalGasUsed *big.Int, err error) {

diff --git a/ethchain/transaction_pool.go b/ethchain/transaction_pool.go
@@ -106,7 +106,7 @@ func (pool *TxPool) ProcessTransaction(tx *Transaction, state *State, toContract
 	sender := state.GetAccount(tx.Sender())
 
 	if sender.Nonce != tx.Nonce {
-		err = fmt.Errorf("[TXPL] Invalid account nonce, state nonce is %d transaction nonce is %d instead", sender.Nonce, tx.Nonce)
+		err = NonceError(tx.Nonce, sender.Nonce)
 		return
 	}
 
@@ -235,7 +235,7 @@ func (pool *TxPool) RemoveInvalid(state *State) {
 		tx := e.Value.(*Transaction)
 		sender := state.GetAccount(tx.Sender())
 		err := pool.ValidateTransaction(tx)
-		if err != nil || sender.Nonce != tx.Nonce {
+		if err != nil || sender.Nonce >= tx.Nonce {
 			pool.pool.Remove(e)
 		}
 	}