Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending multiple transactions in one block won't work #60

Closed
maran opened this issue May 28, 2014 · 1 comment
Closed

Sending multiple transactions in one block won't work #60

maran opened this issue May 28, 2014 · 1 comment
Labels
type:bug

Comments

@maran
Copy link
Member

maran commented May 28, 2014

Only one transaction will be included each block, and every following block will add one more.

2014/05/28 14:00:13 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 9 instead
2014/05/28 14:00:13 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 10 instead
2014/05/28 14:00:13 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 11 instead
2014/05/28 14:00:13 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 12 instead
2014/05/28 14:00:13 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 13 instead
2014/05/28 14:00:13 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 14 instead

2014/05/28 14:00:22 [MINER] 🔨  Mined block 74594d5a1a06b456386b1535ad8f30422dfa49304a5b74c2dec11ed61537ce1b
2014/05/28 14:00:22 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 10 instead
2014/05/28 14:00:22 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 11 instead
2014/05/28 14:00:22 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 12 instead
2014/05/28 14:00:22 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 13 instead
2014/05/28 14:00:22 [TXPL] Invalid account nonce, state nonce is 15 transaction nonce is 14 instead

etc
@maran maran added the bug label May 28, 2014
@obscuren
Copy link
Contributor

Fixed in https://github.com/ethereum/eth-go/commit/b695c82520548f62f65937731def1224c72dce48

fjl pushed a commit to fjl/go-ethereum that referenced this issue Oct 23, 2014
@obscuren
Fixes ethereum#60
b695c82
obscuren pushed a commit that referenced this issue Mar 3, 2015
@winsvega
Merge pull request #60 from winsvega/develop
4b81a98 
ttWrongRLPTransaction
@danielnovy danielnovy mentioned this issue Apr 25, 2015
Closed
gsalgado pushed a commit to gsalgado/go-ethereum that referenced this issue Jul 13, 2017
@jpmsam
Merge pull request ethereum#60 from obscuren/quorum-private-logs
8c47c29 
core, eth: support private state log and bloom filtering
AusIV pushed a commit to NoteGio/go-ethereum that referenced this issue Feb 24, 2020
@meowsbits
Merge pull request ethereum#60 from etclabscore/fix/check-config-fork…
a2e6d0e 
…-order

params: remove and comment CheckConfigForkOrder
recmo pushed a commit to recmo/go-ethereum that referenced this issue Feb 17, 2021
@unclezoro
Merge pull request ethereum#60 from binance-chain/x-forward-for
5a1c39d 
[R4R] Add `x-forward-for` log message when handle message failed
jwasinger added a commit to jwasinger/go-ethereum that referenced this issue Jan 20, 2022
@gballet @jwasinger
Charge witness gas when calling/creating a contract (ethereum#60)
5beac51 
* Charge witness gas when calling/creating a contract

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>

* gofmt

* replace checks with evm.Access!=nil with IsCancun

* remove double-charging of witness access costs for contract creation initialization

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>
@gballet gballet mentioned this issue Mar 18, 2022
Closed
@gballet gballet mentioned this issue May 2, 2022
Closed
holiman pushed a commit to holiman/go-ethereum that referenced this issue Nov 26, 2022
@roberto-bayardo
set min data gas to 1 per latest spec, remove unused ssz hash related…
389ad0a 
… functions (ethereum#60)
zhiqiangxu pushed a commit to zhiqiangxu/go-ethereum that referenced this issue Dec 5, 2022
@blockchaindevsh
fix ancient block (ethereum#60)
7fdd02d 
* fix ancient block

* handle error

* fix error

* modify

* fix

Co-authored-by: blockchaindevsh <blockchaindevsh@google.com>
jsign pushed a commit to jsign/go-ethereum that referenced this issue Feb 15, 2023
@gballet
all: implement EIP-compliant verkle trees
46498e8 
verkle: Implement Trie, NodeIterator and Database ifs

Fix crash in TestDump

Fix TestDump

Fix TrieCopy

remove unnecessary traces

fix: Error() returned errIteratorEnd in verkle node iterator

rewrite the iterator and change the signature of OpenStorageTrie

add the adapter to reuse the account trie for storage

don't try to deserialize a storage leaf into an account

Fix statedb unit tests (ethereum#14)

* debug code

* Fix more unit tests

* remove traces

* Go back to the full range

One tree to rule them all

remove updateRoot, there is no root to update

store code inside the account leaf

fix build

save current state for Sina

Update go-verkle to latest

Charge WITNESS_*_COST gas on storage loads

Add witness costs for SSTORE as well

Charge witness gas in the case of code execution

corresponding code deletion

add a --verkle flag to separate verkle experiments from regular geth operations

use the snapshot to get data

stateless execution from block witness

AccessWitness functions

Add block generation test + genesis snapshot generation

test stateless block execution (ethereum#18)

* test stateless block execution

* Force tree resolution before generating the proof

increased coverage in stateless test execution (ethereum#19)

* test stateless block execution

* Force tree resolution before generating the proof

* increase coverage in stateless test execution

ensure geth compiles

fix issues in tests with verkle trees deactivated

Ensure stateless data is available when executing statelessly (ethereum#20)

* Ensure stateless data is available when executing statelessly

* Actual execution of a statless block

* bugfixes in stateless block execution

* code cleanup

 - Reduce PR footprint by reverting NewEVM to its original signature
 - Move the access witness to the block context
 - prepare for a change in AW semantics
   Need to store the initial values.
 - Use the touch helper function, DRY

* revert the signature of MustCommit to its original form (ethereum#21)

fix leaf proofs in stateless execution (ethereum#22)

* Fixes in witness pre-state

* Add the recipient's nonce to the witness

* reduce PR footprint and investigate issue in root state calculation

* quick build fix

cleanup: Remove extra parameter in ToBlock

revert ToBlock to its older signature

fix import cycle in vm tests

fix linter issue

fix appveyor build

fix nil pointers in tests

Add indices, yis and Cis to the block's Verkle proof

upgrade geth dependency to drop geth's common dep

fix cmd/devp2p tests

fix rebase issues

quell an appveyor warning

fix address touching in SLOAD and SSTORE

fix access witness for code size

touch target account data before calling

make sure the proper locations get touched in (ext)codecopy

touch all code pages in execution

add pushdata to witness

remove useless code in genesis snapshot generation

testnet: fix some of the rebase/drift issues

Fix verkle proof generation in block

fix an issue occuring when chunking past the code size

fix: ensure the code copy doesn't extend past the code size

Upgrade go-verkle to its IPA version (ethereum#24)

fixes for the IPA testnet

upgrade to latest go-verkle

update go-verkle to get more fixes

simplify code by removing all stateless references (ethereum#25)

fix verkle proof test by enforcing values alignment to 32 bytes

remove unneeded KZG tag

fix the stateless test

Move AccessWitness into StateDB (ethereum#27)

* move AccessWitness into StateDB

* set Accesses in TxContext constructor

* Ensures that a statedb is initialized with a witness

* copy AccessWitness in StateDB.Copy.  use copied state in miner worker.commit.

* remove redundant line

Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>

Fix contract creation issue

enable verkle on cancun block: take 2 (ethereum#28)

* enable verkle on cancun block: take 2

* fix typo.  make unreachable line panic message more clear

fix rebase issues

fix linter issue

merge undefined instead of panicking (ethereum#30)

initialize the new access witness if not already present

fix boundary check in PUSH

fix bound check in code chunking

fix boundary condition check in PUSH32

add circleci support (ethereum#32)

* add circleci support

* disable linter, which is broken again

* actually run tests

remove unnecessary cancun block declaration in tests (ethereum#33)

upgrade go version (ethereum#34)

fix calculation in get_tree_key_for_storage_slot (ethereum#35)

use the witness in statedb, revert applyTx signature (ethereum#36)

* use the witness in statedb, revert applyTx signature

* fix miner tests

* fix catalyst build

Remove access witness from the signature of Process (ethereum#38)

consensus/ethash: ensure uncle accounts are included in block witness (ethereum#40)

consensus/ethash: move accumulation of coinbase witness before coinbase account is credited (ethereum#41)

remove outdated comment

miner: embed verkle proof in sealing block (ethereum#39)

* miner: embed verkle proof in sealing block

* add test to ensure that verkle proof is present in mined blocks

Refactor witness-accumulation in EVM (ethereum#42)

* make push dynamically-charged.  charge witness gas costs for push.  refactor evm witness gas charging to move logic for touching a range of bytecode into a helper method 'touchEachChunksAndChargeGas'

* add witness gas calculation for CodeCopy, ExtCodeCopy, SLoad back to gas_table.go

* witness gas charging for CALL

* remove explicit reference to evm.TxContext

* core/vm: make touchEachChunksAndCharge gas handle nil code value

* core/vm: call implementation, separate out witnesses into touch/set

* some fixes

* remove witness touching from opCall: this will go in evm.go

* remove witness touching for call from gas_table.go

* (hopefully) fix tests

* add SSTORE witness charging that was removed mistakenly

* charge witness gas for call

* clean up and comment touchEachChunksAndChargeGas

* make suggested changes

* address remaining points

* fix build issues

* remove double-charging for contract creation witness gas charging

call onleaf in verkle commit (ethereum#45)

replace sha256 with pedersen_hash in get_key (ethereum#46)

* replace sha256 with pedersen_hash

* fix: prevent an OOB

* workaround timeout in unit test

* update go-ipa and reduce the timeout

* fix for unit tests: do not call NewAccessWitness in NewEVMTxContext (ethereum#49)

* potential fix: do not call NewAccessWitness in NewEVMTxContext

* more fixes: check for the existence of Accesses

* fix absence of witness in copy

* fix another witness issue

* workaround: ensure the prefetcher is off in verkle mode

* fix the remaining issues in tests

* review feedback

* fix witness allocation in stateless test

reactivate working lines in test

fix: don't create settings each time a key is calculated (ethereum#53)

fix: don't use rlp in the tree for slot values (ethereum#51)

* fix: don't use rlp in the tree for slot values

* fix timeout after rebase

core/vm: don't include contract deployer bytecode in AccessWitness or charge witness access costs for it (ethereum#54)

Verkle EXTCODECOPY implementation (ethereum#55)

* core/vm: verkle extcodecopy naive way (do jumpdest analysis on target contract every EXTCODECOPY)

* no double-charge

* address edge-case in touchEachChunksAndChargeGas

* simplify line

Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>

Use IsCancun where applicable (ethereum#56)

* replace Accesses != nil with IsCancun(...)

* fix

Charge witness gas when calling/creating a contract (ethereum#60)

* Charge witness gas when calling/creating a contract

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>

* gofmt

* replace checks with evm.Access!=nil with IsCancun

* remove double-charging of witness access costs for contract creation initialization

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>

verkle proof deserialization (ethereum#61)

* use proof serialization

* remove cruft

* save current state

* fix most issues up to this point

* fix remaining build issues

* update the go.mod to use the right branch

* remove custom-defined set type

* update go-verkle to get merged PRs

* extract key, value data from proof

* only activate precomp calculations if this is a verkle chain

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>

fix: build more than one block in stateless test (ethereum#66)

* reproduce the bug

* fix the nil AccessWitness when Resetting

* fix nonce management in blocks

* fix: make sure the snapshot is reused during the chain generation

Fix GetTreeKey (ethereum#65)

* trie/utils: fix GetTreeKey

* disable the faulty test, tracking issue opened

Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>

Implement latest stateless gas charging spec (ethereum#63)

* latest stateless gas-charging spec: add write event charging

* rename gas calculation function so that it doesn't seem it's charging gas

Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>

Various fixes for rust-verkle proof format compatibility (ethereum#67)

* code to extract the block

* separate proof from keys in block

* display state root of block 0

* change file name to reflect the correct block number

* use RLP instead of flat binary for keyvals in block

* update go-verkle to fix build

* fix rebase issues

* make test pass

* fix issue in map copy

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>

Fix contract creation aw (ethereum#68)

* fix contract creation AccessWitness

* remove tracing

* remove tracing

* remove block2.rlp

* move repeated error message into its own error type

fix a couple linter issues

Sload fix (ethereum#69)

* move SLOAD gas calculation to gasSLoadEIP2929

* re-add gasSLoad, used by SSTORE

* make requested changes

fix: witness gas costs being charged more than once (ethereum#70)

* fix: witness gas costs being charged more than one

* update test case

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>

re-enable VerkleTrie::ToDot

core/state: implement GetCodeSize for VerkleDB (ethereum#75)

implement core/state: implement GetCodeSize for VerkleDB

copy the pre-state, use an untouched copy for the proof (ethereum#72)

test to compare the proof format with that of rust verkle (ethereum#73)

* test to compare the proof format with that of rust verkle

* comment block extraction code

check proof in verkle tree test

don't delete from the trie when we encounter empty state object if verkle is enabled (ethereum#74)

core/state: write code to rawdb under codehash key when verkle is enabled (ethereum#76)

force the 32-byte alignment of nonce and balance (ethereum#71)

* force the 32-byte alignment of nonce and balance

* review feedback: fix endianness in output

core/state - ensure storage value is set properly in snapshot when verkle is enabled (ethereum#78)

fixes for the return type change in go-verkle (ethereum#77)

* fixes for the return type change in go-verkle

* update go-verkle

* fix endianness issue + workaround for witness fix

* add changes to miner

Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>

calculate tree index correctly for SLOAD access event (ethereum#79)

core/vm: witness write event for SSTORE (ethereum#80)

* core/vm: witness write event for SSTORE

* remove TODO that is addressed by this branch

fix estimateGas (handle ErrInsufficientBalanceWitness).  Return proper error message when ErrInsufficientBalanceWitness is encountered (ethereum#81)

Verkle/fix/perdersen hash (ethereum#84)

* remove ineffective statement

* fix endianness in pedersen_hash

refactor: set witness account values in getStateObject() (ethereum#83)

* enforce 32-byte alignment

* save current state

* write account values to witness from getObject

* code cleanup + sanity checks

* fix RLP serialization of missing keys

* remove code redundancy for GetTreeKeyCodeChunk

* fix stem calculation issue for code and storage

* remove redundant SetLeafValue calls

* Add a contract creation tx to the test

* fix botched module version update

* detail gas calculation cost in verkle contract deployment

fix verkle trie iterator to not miss leaf values in the first index of a leaf node (ethereum#88)

creation-time CODECOPY adds no code to the witness (ethereum#86)

* creation-time CODECOPY adds no code to the witness

* Add a more complex test to ensure EXTCODECOPY is called

* Fix offset calculations in the slot function

* minor tweaks

* fix initial value capture for storage

* fix build

* fix: get the proper byte in get_tree_key_for_storage_slot

* fix length calculation in getDataAndAdjustedBounds

* fix verkle test

small simplification in order to facilitate rebase

upgrade go-ipa + go-verkle: faster precomp loading

fix: place slot value, not its rlp encoding in witness

fix: code chunification with incorrect header (ethereum#89)

* fix: code chunification with incorrect header

* add a test from rust-verkle and fix offset bug

* fix ci build

* complete coverage of rust-verkle chunking tests

* fix: make sure the witness value is set

* add another code chunking test from rust-verkle

spec: don't add the trailing pushdata for a final PUSHn (ethereum#90)

cleanup: don't evaluate 0 coeffs in get_tree_key (ethereum#87)

ensure no overflow occurs in the chunk touch function

load the full coinbase account in reward

fix: previous commit broke stateless test

rework the way the gas is charged per code chunk

update go-verkle to grab the fix for ethereum#200

fix: don't add PUSH1-data during contract deployment (ethereum#91)

* fix: don't add PUSH1-data during contract deployment

* remove import cycle in tests (ethereum#92)

fix: redundant proof-of-absence stems (ethereum#93)

test: missing children of the same internal node produce a single extension status (ethereum#94)

ParseNode with commitment parameter (ethereum#95)

review feedback for rebase over kiln (ethereum#97)

safe gas add (ethereum#98)

* safe gas add

* fix build

ensure 10-byte addresses are right-aligned in pedersen_hash (ethereum#99)

Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>

Remove the code analysis interface to reduce PR footprint (ethereum#100)

* Remove the code analysis interface to reduce PR footprint

* fix unit test

fix: set IsDeployment=false outside of contract creation (ethereum#101)

remove trailing line

verkle test: count the code chunks in the witness (ethereum#102)

temp fix: little endian pedersen_hash (ethereum#103)

factor the amount of polynomial evaluations in access witness (ethereum#106)

reuse polynomial evaluation in account update (ethereum#108)

fix: remove redundant balance touching in access witness (ethereum#107)

add github workflow

reuse address point evaluation in code chunking (ethereum#109)
luanxu-mxc pushed a commit to MXCzkEVM/mxc-geth that referenced this issue May 27, 2023
@davidtaikocha
chore(taiko_genesis): update genesis JSONs (ethereum#60)
e06b8e6
protolambda pushed a commit to protolambda/go-ethereum that referenced this issue Jul 14, 2023
@ajsutton
ethapi: Omit isSystemTx: "false" from JSON-RPC responses (ethereum#60)
b9bbfdf
sbellem pushed a commit to sbellem/go-ethereum that referenced this issue Jul 25, 2023
@dartdart26
Merge pull request ethereum#60 from zama-ai/petar/ct-handle-in-call-a…
a3fc1a7 
…rg-depth-set-impl

Delegate handles found in call arguments
lochjin pushed a commit to lochjin/go-ethereum that referenced this issue Oct 27, 2024
@dindinw
Merge pull request ethereum#60 from lochjin/v1.14.11-qng
0414844 
feat:Force update pending on miner for qng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maran @obscuren