switching account fields in gl model

[fivetran-joemarkiewicz]

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR changes the account_code, account_id, account_name, and account_type fields within the xero_general_ledger to now being selected from the stg_xero__account model instead of the stg_xero__journal_line model.

It was found that account names may be changed within Xero, but the account name within a journal line entry will remain the old name. As such, this fix will ensure all records on the xero__general_ledger and downstream models reflect the most up to date name of the account.

Does this PR introduce a breaking change?

• Yes (please provide breaking change details below.)
• No (please provide explanation how the change is non breaking below.)

We are only changing the base table these fields are being selected from. Therefore, this will not result in a breaking change for existing users.

Is this PR in response to a previously created Issue

• Yes, Issue BUG - unique_xero__profit_and_loss_report_profit_and_loss_id fails when account_name column differs #18
• No

How did you test the PR changes?

• CircleCi
• Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

• BigQuery
• Redshift
• Snowflake
• Postgres
• Databricks
• Other (provide details below)

Provide an emoji that best describes your current mood

💰

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

[fivetran-joemarkiewicz]

These changes were tested within Issue #18 and proved to be succesful and resolve the unique dbt test error within the users environment.

As this was tested by the user who raised the issue I am comfortable merging this into the next release.