Merge pull request #22 from fivetran/hotfix/gl-update-account-fields

switching account fields in gl model

Author: fivetran-joemarkiewicz

CHANGELOG.md

@@ -1,3 +1,8 @@
+# dbt_xero v0.3.1
+## Bug Fix
+- The `account_code`, `account_id`, `account_name`, and `account_type` fields within the `xero_general_ledger` are now being selected from the `stg_xero__account` model instead of the `stg_xero__journal_line` model. 
+  - It was found that account names may be changed within Xero, but the account name within a journal line entry will remain the old name. As such, this fix will ensure all records on the `xero__general_ledger` and downstream models reflect the most up to date name of the account.
+
 # dbt_xero v0.3.0
 
 ## Features

dbt_project.yml

@@ -1,5 +1,5 @@
 name: 'xero'
-version: '0.3.0'
+version: '0.3.1'
 config-version: 2
 require-dbt-version: [">=0.20.0"]
 
@@ -20,4 +20,4 @@ models:
     +materialized: table
     +schema: xero
     utilities:
-       +materialized: ephemeral
+      +materialized: ephemeral

integration_tests/dbt_project.yml

@@ -1,5 +1,5 @@
 name: 'xero_integration_tests'
-version: '0.3.0'
+version: '0.3.1'
 profile: 'integration_tests'
 config-version: 2
 

models/xero__general_ledger.sql

@@ -45,20 +45,18 @@ with journals as (
         journals.reference,
         journals.source_id,
         journals.source_type,
-        journals.source_relation, 
-
+        journals.source_relation,
         journal_lines.journal_line_id,
-        journal_lines.account_code,
-        journal_lines.account_id,
-        journal_lines.account_name,
-        journal_lines.account_type,
+        accounts.account_code,
+        accounts.account_id,
+        accounts.account_name,
+        accounts.account_type,
         journal_lines.description,
         journal_lines.gross_amount,
         journal_lines.net_amount,
         journal_lines.tax_amount,
         journal_lines.tax_name,
         journal_lines.tax_type,
-
         accounts.account_class,
 
         case when journals.source_type in ('ACCPAY', 'ACCREC') then journals.source_id end as invoice_id,