Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename net income retained earnings adjustment column #66

Conversation

fivetran-avinash
Copy link
Contributor

Are you a current Fivetran customer?

What change(s) does this PR introduce?

Modified int_quickbooks__retained_earnings intermediate model to more accurately reflect retained earnings accounts as "Net Income Adjustment".

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)
    The change is only adding modifying a field.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes (This is being merged into a non-main branch, where we will update the dbt_project versions when it's ready to merge.

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • BuildKite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🍎

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-avinash fivetran-avinash changed the title Feature/rename net income retained earnings adjustment column Rename net income retained earnings adjustment column Dec 19, 2022
@fivetran-avinash fivetran-avinash self-assigned this Dec 19, 2022
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a few small comments and questions. Once they are applied we this looks good to me!

I do think the customer has an additional ask in generating the previous periods net income in the form of a true retained earnings field. That will be a bigger lift and can exist outside of this PR and task.

@fivetran-avinash fivetran-avinash merged commit b18a220 into feature/quickbooks-updates-project Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants