Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Break out Net Income from Retained Earnings #57

Closed
2 of 4 tasks
mel-restori opened this issue Nov 23, 2022 · 9 comments
Closed
2 of 4 tasks

[Feature] Break out Net Income from Retained Earnings #57

mel-restori opened this issue Nov 23, 2022 · 9 comments
Assignees
Labels
priority:p3 Affects many users; can wait status:in_review Currently in review type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@mel-restori
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Today, Fivetran combines Net Income and Retained earnings into one line item (called "Net Income / Retained Earnings Adjustment"), but the QuickBooks UI breaks them out separately. It would be helpful for comparisons for them to be broken out. Relevant code is here.

Thank you!

Attaching redacted screenshot from QuickBooks
Screen Shot 2022-11-23 at 9 46 28 AM

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@mel-restori mel-restori added the enhancement New feature or request label Nov 23, 2022
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @mel-restori I think it may be best if we instead renaming the "Net Income / Retained Earnings Adjustment" field. This field is generated by capturing the Net Income adjustment from the relevant period. This can sometimes be referred to as the retained earnings adjustment as well. However, if you have your own Retained Earnings account (which is seems you do) then I could see the naming of this field to be duplicative.

Can you confirm that your end models product a Retained Earnings record for a given period as well as a Net Income / Retained Earnings Adjustment record? If so, then I think this should be an easy feature to roll into our next update to rename the field to Net Income Adjustment.

@mel-restori
Copy link
Contributor Author

Hi @fivetran-joemarkiewicz thanks for following up.
I'll first admit that I really don't know much about accounting, figuring it out on the fly while I reconcile the Quickbooks UI balance sheet from the Fivetran data model balance sheet. But in Quickbooks, it doesn't look like "Retained Earnings" is a separate account - and it's the only value that I can't click on to drill down into. I was able to figure out that that amount matches the sum of net income from previous time periods, though. So it seems like it's how it carries forward the net income from previous years and then keeps the "net income" row only for the time period selected in the report.
I got to this through trial an error so maybe what I'm saying doesn't make sense.

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks for this insight @mel-restori! Based on this discovery I think my initial idea would probably be the best course of action to make the record more clear. These "Net Income / Retained Earnings Adjustment" records are simply calculating the "net income" for the periods and factors it into the current BS period. Therefore, renaming the field to just be "Net Income Adjustment" would be more appropriate in my eyes and also allow for it to not be confused with a true Retained Earnings account.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added update_type:models Primary focus requires model updates status:accepted Scoped and accepted into queue type:bug Something is broken or incorrect priority:p3 Affects many users; can wait and removed enhancement New feature or request labels Dec 14, 2022
@mel-restori
Copy link
Contributor Author

@fivetran-joemarkiewicz that sounds right, but we also need to get the net income from previous periods in order to match the balance sheet in the Quickbooks UI

@fivetran-avinash fivetran-avinash added type:enhancement New functionality or enhancement status:in_progress Currently being worked on and removed type:bug Something is broken or incorrect status:accepted Scoped and accepted into queue labels Dec 17, 2022
@fivetran-avinash
Copy link
Contributor

Hi @mel-restori, I'm working on this feature now. Could you elaborate on what you mean about the balance sheet not matching net income from previous periods? It seemed in the previous comment that this solution would work, or do you think there is additional logic required to get the matching you're looking for?

@fivetran-avinash fivetran-avinash added status:in_review Currently in review and removed status:in_progress Currently being worked on labels Dec 19, 2022
@mel-restori
Copy link
Contributor Author

Hi @fivetran-avinash - I think maybe I don't understand the solution proposed.
In the QB UI, I see a line for "Net Income" which is the specified time period's net income. Then there's another line for Retained Earnings, which appears to be the sum of net income from all previous time periods. I would like to have the same two lines in this balance sheet. It think it would be fine for the past net income to be called "Net Income Adjustment" instead of "Retained Earnings", as long as it gives the correct value.
Thank you!

@fivetran-avinash
Copy link
Contributor

fivetran-avinash commented Dec 21, 2022

Thanks for the context @mel-restori!

We have fixed the field to correctly reflect "Net Income Adjustment". We plan on merging this into our main branch in the New Year! You can view the PR for now if you want to see what it looks like. #66

We will try to address creating the Retained Earnings definition you're looking for in a future sprint.

Let me know if you have any questions! Happy to assist.

@mel-restori
Copy link
Contributor Author

thanks!

@fivetran-avinash fivetran-avinash added status:in_review Currently in review and removed status:in_review Currently in review labels Jan 10, 2023
@fivetran-avinash
Copy link
Contributor

Hi @mel-restori ! We have deployed this fix in the 0.7.0 version of our package. If you upgrade your packages.yml to any version of 0.7.0 or above (we recently deployed 0.8.0) you should be able to see "Net Income Adjustment" correctly reflected.

We are going to close this issue, but if have any questions, thoughts or feedback, please let us know in this issue!

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Affects many users; can wait status:in_review Currently in review type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

3 participants