Updated test for stg_qualtrics__distribution_contact
#9
+35
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Distribution contact test
4 tasks
fivetran-avinash
changed the title
stg_qualtrics__distribution_contact
fivetran-catfritz
requested changes
Aug 26, 2024
CHANGELOG.md
Outdated
| @@ -1,3 +1,12 @@ | |||
| # v0.2.2 dbt_qualtrics_source | |||
There was a problem hiding this comment.
Suggested change
| # v0.2.2 dbt_qualtrics_source | |
| # dbt_qualtrics_source v0.2.2 |
Updating for compatibility with the auto releaser.
CHANGELOG.md
Outdated
| - Updated unique combination of columns test on `stg_qualtrics__distribution_contact` to include `contact_lookup_id`. [PR #8](https://github.com/fivetran/dbt_qualtrics_source/pull/8) | ||
|
|
||
| ## Contributors | ||
| - [@dmcmtntp](https://github.com/dmcmtntp) [PR #8](https://github.com/fivetran/dbt_qualtrics_source/pull/8) |
There was a problem hiding this comment.
Suggested change
| - [@dmcmtntp](https://github.com/dmcmtntp) [PR #8](https://github.com/fivetran/dbt_qualtrics_source/pull/8) | |
| - [@dmcmtntp](https://github.com/dmcmtntp) ([PR #8](https://github.com/fivetran/dbt_qualtrics_source/pull/8)) |
Tiny formatting suggestion.
There was a problem hiding this comment.
Formattnig applied
CHANGELOG.md
Outdated
| [PR #9](https://github.com/fivetran/dbt_qualtrics_source/pull/9) includes the following updates: | ||
|
|
||
| ## Bug Fix | ||
| - Updated unique combination of columns test on `stg_qualtrics__distribution_contact` to include `contact_lookup_id`. [PR #8](https://github.com/fivetran/dbt_qualtrics_source/pull/8) |
There was a problem hiding this comment.
I would add a reason why it had to be added (was it accidentally omitted or was there a connector update, etc?)
fivetran-catfritz
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#7]
This PR will result in the following new package version: v0.2.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fix
stg_qualtrics__distribution_contactto includecontact_lookup_id. PR #8PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Customer was able to validate that the new test didn't fail.
If you had to summarize this PR in an emoji, which would it be?
🤝