-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribution contact test #8
Distribution contact test #8
Conversation
Thanks @dmcmtntp for opening this as well as providing the underlying versioning and changelog updates ! We'll wrap this into an upcoming sprint and get it released! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dmcmtntp! Thanks for alerting us to this bug and creating a PR!
I have a few suggested changes before we merge this into a development branch (there are a few internal processes we have to kick off before we merge into main
). Once those are applied, I will go ahead and merge these into the branch and we will be closer to having these errors fixed!
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
changes committed! |
Thanks for that @dmcmtntp ! I have merged your changes into our branch and am hoping that we will be able to release these changes sometime later this week! We will keep you in the loop. |
great, thank you! |
Please provide your name and company
Devin McManus, TNTP
Link the issue/feature request which this PR is meant to address
#7
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
adds contact_lookup_id to the distribution_contact unique test here:
dbt_qualtrics_source/models/stg_qualtrics.yml
Lines 562 to 566 in 36dfc65
How did you validate the changes introduced within this PR?
Ran test in TNTP development environment
Which warehouse did you use to develop these changes?
TNTP snowflake instance
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
🤷♂️
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)