Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution contact test #8

Conversation

dmcmtntp
Copy link
Contributor

Please provide your name and company
Devin McManus, TNTP

Link the issue/feature request which this PR is meant to address

#7

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
adds contact_lookup_id to the distribution_contact unique test here:

- dbt_utils.unique_combination_of_columns:
combination_of_columns:
- contact_id
- distribution_id
- source_relation

How did you validate the changes introduced within this PR?

Ran test in TNTP development environment

Which warehouse did you use to develop these changes?

TNTP snowflake instance

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Provide an emoji that best describes your current mood

🤷‍♂️

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@fivetran-reneeli
Copy link
Contributor

Thanks @dmcmtntp for opening this as well as providing the underlying versioning and changelog updates ! We'll wrap this into an upcoming sprint and get it released!

@fivetran-avinash fivetran-avinash changed the base branch from main to test/distribution-contact August 23, 2024 00:29
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dmcmtntp! Thanks for alerting us to this bug and creating a PR!

I have a few suggested changes before we merge this into a development branch (there are a few internal processes we have to kick off before we merge into main). Once those are applied, I will go ahead and merge these into the branch and we will be closer to having these errors fixed!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
dmcmtntp and others added 2 commits August 24, 2024 09:20
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
@dmcmtntp
Copy link
Contributor Author

changes committed!

@fivetran-avinash fivetran-avinash merged commit aaa5938 into fivetran:test/distribution-contact Aug 26, 2024
@fivetran-avinash
Copy link
Contributor

Thanks for that @dmcmtntp ! I have merged your changes into our branch and am hoping that we will be able to release these changes sometime later this week! We will keep you in the loop.

@dmcmtntp
Copy link
Contributor Author

great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants