add pass through for vendors and items #23
Conversation
There was a problem hiding this comment.
@rpalloni thanks again for opening this PR! I have just a few small requests to edit your PR before this will be good to go. Let me know if you have any questions!
CHANGELOG.md
Outdated
| - Added this changelog to capture iterations of the package! | ||
| - Added the `vendors_pass_through_columns` variable to be leveraged within the `stg_netsuite__vendors` model. This variable will allow users to pass through fields which are not natively included to the package staging model. This variable is empty by default and may be overridden within a users root `dbt_project.yml`. | ||
| - Added the `items_pass_through_columns` variable to be leveraged within the `stg_netsuite__items` model. This variable will allow users to pass through fields which are not natively included to the package staging model. This variable is empty by default and may be overridden within a users root `dbt_project.yml`. |
There was a problem hiding this comment.
Can you link this PR in the CHANGELOG notes? See below for how we did it in past entries.
There was a problem hiding this comment.
Ooops! Yes sure #23
fivetran-joemarkiewicz
changed the base branch from
main
to
MagicBot/dbt-utils-cross-db-migration
There was a problem hiding this comment.
@rpalloni thanks so much for updating your PR and for contributing to the package. These variables will be a great addition for folks to be able to leverage! 🏅
I have approved the PR, but will be merging it into our existing MagicBot/dbt-utils-cross-db-migration branch as we are planning a large scale migration of all our packages for dbt utils v1.0.0 and dbt-core v1.3.0 compatibility. As such, I am folding your changes into this effort.
If you need to use your changes immediately, you can leverage your forked branch and wait to swap over to the official hub version once we roll these changes out. Let me know if you have any questions. Thanks again!!
fivetran-joemarkiewicz
merged commit d7f333b
into
fivetran:MagicBot/dbt-utils-cross-db-migration
|
Ok cool! Found a temporary fix in the meanwhile so I think I'll wait for the large scale migration. Any idea on when it will be? |
|
Awesome! Next week our team will be at the Coalesce Conference and we will plan to make a team wide effort to roll these out the following week. However, this large scale release is all dependent on when dbt-utils v1.0.0 officially releases. |
|
Hi @fivetran-joemarkiewicz , any news on this? Thanks |
|
Hey @ropalloni apologies for the late reply as I am just getting back from the holiday PTO. Thanks for asking about this, and we will be releasing these updates this week! You should see all our packages updates before the end of the week. Thanks! |
|
Ok now it works. However you did not align netsuite2 with the same fix.... |
|
Hi @ropalloni thanks for raising this to me. You are correct that we missed in this PR to persist the items and vendors passthrough columns to the netsuite2 models. We can account for this in the next release of the netsuite package. Is this currently a blocker for you? |
|
When will be next release? |
|
There is no slated release of the netsuite_source package, but we could realistically work to fold this into either this week or next week. |
|
This week or next week would be perfect! Btw it's just adding the same macro in those models. Let me know. |
|
Sounds great! Yeah this should be a pretty simple update, but want to be realistic with the other changes (across our other packages) that are taking place in our current sprint. I just created a new issue (above) for us to be able to track this bug fix. I also marked it as a good first issue in case others come across and want to contribute to the package before my team is able to get to it. |
|
Hi @fivetran-joemarkiewicz ! Do you have any updates on this? Thanks |
Are you a current Fivetran customer?
Yes
What change(s) does this PR introduce?
It allows to extend the fields in stg models as regards vendors and items
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Edit package in my local project and run the model creation. Successful after introducing fixing.
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.