[Bug] Persist Item and Vendor Passthrough Columns for Netsuite2

[fivetran-joemarkiewicz]

Is there an existing issue for this?

• I have searched the existing issues

Describe the issue

PR #23 added passthrough columns for items and vendors into the Netsuite1 models. However, the same changes were not applied to the Netsuite2 models in the package. The passthrough columns should work as intended for both the Netsuite and Netsuite2 forms of this package.

Relevant error log or model output

M/A

Expected behavior

Passthrough columns defined for items and vendors persist when using both Netsuite and Netsuite2 models.

dbt Project configurations

vars:
vendors_pass_through_columns:
- name: "vendors_custom_field"
alias: "vendors_field"
items_pass_through_columns:
- name: "items_custom_field"
alias: "items_field"

Package versions

v0.6.0

What database are you using dbt with?

postgres, redshift, snowflake, bigquery, databricks

dbt Version

v1.3.1

Additional Context

The code within the stg_netsuite__items and stg_netsuite__vendors can simply be copy/pasted into the Netsuite2 counterpart models to address this issue.

Are you willing to open a PR to help address this issue?

• Yes.
• Yes, but I will need assistance and will schedule time during our office hours for guidance
• No.

[fivetran-jamie]

i noticed that these passthrough columns are not in the transform package, though these tables are indeed brought into the transaction_details model.... should we also add the vendor/item passthrough columns to the transform package while we're at it? @fivetran-joemarkiewicz

[fivetran-joemarkiewicz]

Following our conversation offline, let's plan to not persist the passthrough columns through for now. However, if we could create a complimentary FR to track this idea that would be great!

[fivetran-joemarkiewicz]

Closing as this has been addressed in the above PRs.