Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating target schemas #33

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

rajan-lw
Copy link
Contributor

Are you a current Fivetran customer?
Yes, Manger, Data Analytics, Lacework

What change(s) does this PR introduce?
This will add missing target schema configuration

Did you update the CHANGELOG?

Yes
Does this PR introduce a breaking change?

Yes (please provide breaking change details below.)
No (please provide an explanation as to how the change is non-breaking below.)
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Yes
Is this PR in response to a previously created Bug or Feature Request

Yes, Issue/Feature [https://github.com/https://github.com/fivetran/dbt_github/issues/47]
No
How did you test the PR changes?

Buildkite
Local (please provide additional testing details below)
Select which warehouse(s) were used to test the PR

BigQuery
Redshift
Snowflake
Postgres
Databricks
Other (provide details below)
Provide an emoji that best describes your current mood

🕺🏻

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajan-lw!

When you have a moment, would you also be able to index the version of the package within the dbt_project.yml and integration_tests/dbt_project.yml to be v0.8.0. Additionally, if you could create a new entry in the CHANGELOG for these updates and properly bump the versions in the README that would be great!

Once those updates are applied we can work to integrate these into the next release!

@fivetran-catfritz fivetran-catfritz self-assigned this Mar 21, 2024
@fivetran-catfritz fivetran-catfritz added priority:p2 Affects most users; fix needed type:enhancement New functionality or enhancement status:in_progress Currently being worked on update_type:feature Primary focus is to add new functionality and removed priority:p2 Affects most users; fix needed type:enhancement New functionality or enhancement status:in_progress Currently being worked on update_type:feature Primary focus is to add new functionality labels Mar 21, 2024
@fivetran-catfritz fivetran-catfritz changed the base branch from main to release/v0.8.0 March 21, 2024 23:31
@fivetran-catfritz fivetran-catfritz merged commit e5ea645 into fivetran:release/v0.8.0 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants