Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing target schemas config in dbt_package.yml #47

Closed
2 of 4 tasks
rajan-lw opened this issue Apr 17, 2023 · 2 comments · Fixed by #53 or fivetran/dbt_github_source#39
Closed
2 of 4 tasks

Missing target schemas config in dbt_package.yml #47

rajan-lw opened this issue Apr 17, 2023 · 2 comments · Fixed by #53 or fivetran/dbt_github_source#39
Assignees
Labels
priority:p2 Affects most users; fix needed status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@rajan-lw
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

We have installed the dbt package for github but when we run the models it does not create a target schemas. So comparing the code with Jira package.

In Jira package dbt_package.yml file config

models:
  jira:
    +materialized: table
    +schema: jira
    intermediate:
      +materialized: ephemeral
      +schema: int_jira

In Github package dbt_package.yml file config

models:
  github:
    materialized: table
    intermediate:
      materialized: ephemeral

Relevant error log or model output

NA

Expected behavior

Should be creating int tables and model tables in the *_int_github and *_github location.

dbt Project configurations

NA

Package versions

  • package: fivetran/github
    version: [">=0.7.0", "<0.8.0"]

What database are you using dbt with?

snowflake

dbt Version

1.3

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-joemarkiewicz
Copy link
Contributor

HI @rajan-lw thanks for raising this and opening the PRs to address the update!

I agree with you that we should update the packages to build the models in the same format as our other packages by default. However, I did want to note that you can also define this in your root dbt_project.yml to override the package targets. See the section in our README for a description on how this can be done.

With that being said, we will likely accept your PRs and review to work to get the updates rolled out into the latest releases. One thing to note is that changing the target schema by default will result in breaking changes (v0.8.0 for dbt_github and v0.8.0 for dbt_github_source). As such, we will likely hold off on merging these until we have other breaking changes to integrate into the next breaking release. I will still review, but wanted to keep you updated on the status.

Thanks again!

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the type:enhancement New functionality or enhancement label Apr 18, 2023
@fivetran-catfritz fivetran-catfritz self-assigned this Mar 21, 2024
@fivetran-catfritz fivetran-catfritz added priority:p2 Affects most users; fix needed status:in_progress Currently being worked on update_type:feature Primary focus is to add new functionality labels Mar 21, 2024
@fivetran-catfritz
Copy link
Contributor

Hi @rajan-lw to update you, I will be adding in your target schema PRs in the next week or so. I will merge your PRs into my branches and then make some additional changes related to other issues. I'll post back here when it is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p2 Affects most users; fix needed status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants