Feature/add conversions

[fivetran-jamie]

PR Overview

This PR will address the following Issue/Feature:
no issue made

This PR will result in the following new package version:

v0.8.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates

Introducing...conversion metrics (PR #43)!

• Adds a conversion_value field to each _report end model, representing the value of conversions (calculated using the default attribution window set in Meta) that occurred on each day for each ad/campaign/ad set/url/account.
• Creates a facebook_ads__basic_ad_actions_passthrough_metrics variable to pass through additional conversion value metrics that are calculated using different attribution windows.
  • By default, the package includes only the conversion value calculated using the default attribution window, but your report may include calculations using the other windows defined here. See README for details on how to use the new var.

Documentation

• Documents the ability to transform metrics provided to the facebook_ads__basic_ad_passthrough_metrics variable. See README for details (PR #43).

Under the Hood

• Updated the quickstart.yml file to allow for automated Quickstart data model deployments (PR #40).
• Updated the PR templates to align with our most up-to-date standards (PR #43).

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned
• All necessary documentation and version upgrades have been applied
• docs were regenerated (unless this PR does not include any code or yml updates)
• BuildKite integration tests are passing
• Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Tests are passing

1. Horizontal integrity test compares total sum of conversion_value from each _report end model
2. Consistency tests compare clicks, impressions, and spend across dev and prod in each of the _report models

No exceptions needed, just a teeny tiny buffer to account for differences in rounding

[fivetran-joemarkiewicz]

@fivetran-jamie these changes look great! I just have a few minor suggestions, but none related to the actual code. I see this being a huge value add for our users!

Once you address the comments in this review let's hold off merging until the other updates in the Google and LinkedIn packages are ready as well. Thanks and great job!

[fivetran-joemarkiewicz]

Reminder to swap before merge

[fivetran-joemarkiewicz]

Just to confirm, should 0 and null be represented the same here?

[fivetran-jamie]

yeah, though i have actually yet to see a null (or even 0) conversion value recorded in basic_ad_actions

the individual/passthrough values are null when representing 0 however

[fivetran-joemarkiewicz]

Thanks for confirming. Good to see we haven't seen null in the conversion value, but great to see we are being proactive with this logic. This looks good to me!

[fivetran-catfritz]

@fivetran-jamie @fivetran-joemarkiewicz Now might be a good time to delete the defunct 2nd reviewer bot.

[fivetran-joemarkiewicz]

@fivetran-jamie @fivetran-joemarkiewicz Now might be a good time to delete the defunct 2nd reviewer bot.

Agreed! @fivetran-jamie would you be able to remove that from this branch.

[maxtuzz]

Great effort! Looking forward to this release.

[fivetran-jamie]

FYI for anyone subscribed here, this is currently blocked.

We are working with Engineering to ensure that the conversion monetary values (action_values) are included in a default report and therefore accessible to the package (currently, only the raw # of conversions are supported by the basic_ad_actions report).