Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/quickstart-update #40

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jan 3, 2024

PR Overview

This PR will address the following Issue/Feature: This is an internal update that is not tied to an existing issue

This PR will result in the following new package version: This will not result in a new version for the package

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Please note this will not result in a new release. This CHANGELOG entry will only be included so it may be captured in the next release.

Under the Hood

  • Updated the quickstart.yml file to allow for automated Quickstart data model deployments.

PR Checklist

Basic Validation

Validation was not necessary as this change only is to the quickstart.yml which is not used by package users. This change is only to reflect updates to the format of the quickstart.yml to allow automated quickstart deployments. I am comfortable with these changes as BuildKite is passing.

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

See above. There were no validation steps as this is only to update the quickstart.yml file and has no impact on data model users.

If you had to summarize this PR in an emoji, which would it be?

🤖

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Jan 3, 2024
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review January 3, 2024 16:26
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-data-model-bot fivetran-data-model-bot requested review from a team, fivetran-jamie and fivetran-reneeli and removed request for a team January 4, 2024 15:33
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 454a4d6 into main Jan 4, 2024
8 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the feature/quickstart-update branch January 4, 2024 15:34
@fivetran-jamie fivetran-jamie mentioned this pull request May 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants