Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold in major releases from Google Ads and Linkedin Ads #115

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Jul 29, 2024

PR Overview

This PR will address the following Issue/Feature:
fivetran/dbt_google_ads#47

Merge in:

This PR will result in the following new package version:

v1.9.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Under the Hood

  • Addition of a section tag within the README so the model descriptions may be accessible within the Fivetran UI for Quickstart. (PR #113)
  • Upticked the google_ads and linkedin_ads dependencies following major releases in both packages in which conversion metrics have been added. Refer to the individual package release notes for more details (Google Ads, Linkedin Ads). (PR #115)
    • Note: Conversions have not been added to ad_reporting models yet, as we are rolling out conversion support to all upstream Ad packages first.

Contributors

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

See validations in Google and Linkedin transform PRs

❗ Special Updates for Ad Reporting ❗

To reduce integration testing time, not all models should be enabled in the run_models.sh vars. Update the variables after dbt run and dbt test to set:

  • this PR's package to true
  • Google Ads and Facebook Ads to true (if not already)
  • All other packages to false

Detailed Validation

Please share any and all of your validation steps:

If you had to summarize this PR in an emoji, which would it be?

💃

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small wording comment and then waiting on some questions in the upstream PRs. However, I wanted to send this out sooner than later so it can be quickly addressed before next review.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie thanks for creating this PR! I do just have one small CHANGELOG request which does not need to be blocking for approval.

Fivetran-milanjovic and others added 2 commits July 30, 2024 09:14
* Update README.md

Added a new blank line between lines 44 and 45 of the README.md

* Update CHANGELOG.md
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-jamie fivetran-jamie merged commit 8a6da2f into main Jul 30, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants