Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] include conversions metric #47

Open
2 of 4 tasks
jbradysmith opened this issue May 19, 2023 · 1 comment
Open
2 of 4 tasks

[Feature] include conversions metric #47

jbradysmith opened this issue May 19, 2023 · 1 comment
Assignees

Comments

@jbradysmith
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

The existing job summarizes clicks and impressions. a summary of conversions grouped by account, campaign, and date is also needed.

Describe alternatives you've considered

We actually jon the derived dbt table back to the source table in order to achieve the same end result in a sql view. It would be easier/cleaner to have the dbt job generate this view.

-- postresql with t2 as (Select ags.date, ags.campaign_id, sum(ags.conversions) as conversions from fivetran_google_ads.ad_group_stats ags group by 1, 2) select 'Google Ads' as source, t1.date_day, t1.account_name, t1.account_id, t1.campaign_name, t1.campaign_id, sum(t1.spend) as spend, sum(t1.clicks) as clicks, sum(t1.impressions) as impressions, t2.conversions from fivetran_google_ads_google_ads.google_ads__ad_group_report t1 join t2 on t1.campaign_id = t2.campaign_id and t1.date_day = t2.date group by 2, 3, 4, 5, 6, t2.conversions;

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-joemarkiewicz
Copy link
Contributor

Hey @jbradysmith you can actually bring conversions in within the latest release of the package! While it is not a default field in the model, you can include conversions as a passthrough metric via the passthrough variables. You can see more instructions on how to do this within our README section on the topic.

Let me know if this does the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants