Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PersonifyAuthController.php to not grant access to Cancelled/Expired members (master) #279

Merged
merged 9 commits into from
Mar 1, 2021

Conversation

retif
Copy link

@retif retif commented Feb 26, 2021

Canceled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify. Fixes in auth() and userHasActiveMembership() address that problem.

Related Issue/Ticket: ymcatwincities#114

Cherry-picked from #271

Steps to test:

  • Use a member that has a canceled or expired membership.
  • Attempt to log in with that member.
  • Login was successful when it should not have permitted the member to log in. now the user will see the message with the Try Again button as seen in the following screenshot.

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

Cancelled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify.  Fixes in auth() and userHasActiveMembership() address that problem.
hamrant
hamrant previously approved these changes Feb 26, 2021
@AnastasiiaPys
Copy link

Tested, found an issue.
Try again button doesn't redirect user to personify login page so user hasn't an ability to enter his credentials again.
See video below
https://monosnap.com/file/yMf3FzhWi9wce25fC3zeqZNxV72M0Q

@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@fivejars fivejars deleted a comment from fjbot Mar 1, 2021
@AnastasiiaPys
Copy link

Tested, looks good for me.

Copy link

@AnastasiiaPys AnastasiiaPys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good!

@anpolimus anpolimus merged commit a551d58 into fivejars:master Mar 1, 2021
@retif retif deleted the personify-fix branch March 1, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants