forked from ymcatwincities/openy_gated_content
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PersonifyAuthController.php to not grant access to Cancelled/Expired members (master) #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cancelled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify. Fixes in auth() and userHasActiveMembership() address that problem.
hamrant
previously approved these changes
Feb 26, 2021
Tested, found an issue. |
anpolimus
suggested changes
Mar 1, 2021
...les/openy_gc_auth/modules/openy_gc_auth_personify/src/Controller/PersonifyAuthController.php
Outdated
Show resolved
Hide resolved
anpolimus
reviewed
Mar 1, 2021
modules/openy_gc_auth/modules/openy_gc_auth_personify/src/Client.php
Outdated
Show resolved
Hide resolved
Tested, looks good for me. |
AnastasiiaPys
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canceled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify. Fixes in auth() and userHasActiveMembership() address that problem.
Related Issue/Ticket: ymcatwincities#114
Cherry-picked from #271
Steps to test:
Quality checks:
Please check these boxes to confirm this PR covers the following cases:
hook_update_N
or other means.team in Slack