Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PersonifyAuthController.php to not grant access to Cancelled/Expired members #271

Merged
merged 4 commits into from
Feb 18, 2021

Conversation

TomScarboroughYMCA
Copy link

Cancelled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify. Fixes in auth() and userHasActiveMembership() address that problem.

Related Issue/Ticket: ymcatwincities#114

Steps to test:

  • Use a member that has a cancelled or expired membership.
  • Attempt to log in with that member.
  • Login was successful when it should not have permit the member to log in. now the user will see the message with the Try Again button as seen in the following screenshot.

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

Cancelled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify.  Fixes in auth() and userHasActiveMembership() address that problem.
@fivejars fivejars deleted a comment from fjbot Feb 17, 2021
@fivejars fivejars deleted a comment from fjbot Feb 17, 2021
@fivejars fivejars deleted a comment from fjbot Feb 17, 2021
@fivejars fivejars deleted a comment from fjbot Feb 17, 2021
@fivejars fivejars deleted a comment from fjbot Feb 17, 2021
@fivejars fivejars deleted a comment from fjbot Feb 17, 2021
@hamrant hamrant added bug Something isn't working NEEDS REVIEW NEEDS TESTING labels Feb 17, 2021
Copy link

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok for me

Copy link

@retif retif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did setup personify settings on build server, tested both test users with active and inactive subscription, works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working REVIEWED TESTED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants