-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PersonifyAuthController.php to not grant access to Cancelled/Expired members #271
Conversation
Cancelled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify. Fixes in auth() and userHasActiveMembership() address that problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did setup personify settings on build server, tested both test users with active and inactive subscription, works as expected.
Cancelled and Expired Virtual YMCA members were gaining access to Virtual Y sites that use Personify. Fixes in auth() and userHasActiveMembership() address that problem.
Related Issue/Ticket: ymcatwincities#114
Steps to test:
Quality checks:
Please check these boxes to confirm this PR covers the following cases:
hook_update_N
or other means.team in Slack