[PRODDEV-111] Request verification only once per browser #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PRODDEV-188] Fix Activity Log export if user is null
ReClique SSO Integration in openy_gc_auth_reclique_sso module
[YGBWSVY-34] Fix user login issue
[VYMCA-130] Fix pager in shared content
hamrant
previously approved these changes
Feb 8, 2021
Migrate Virtual Y small banner image
NightHunterSV
force-pushed
the
PRODDEV-111
branch
from
3848616 to
b53f466
Compare
# Conflicts: # js/gated-content/dist/gated-content.umd.min.js # modules/openy_gc_log/src/LogArchiver.php
|
retest |
|
tested , all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openy.atlassian.net/browse/PRODDEV-111
Steps to test:
Log in as an admin
Enable "Open Y Virtual YMCA Auth Custom" module (at
/admin/modules)Check the
Custom provideron the Virtual YMCA Auth settings page (/admin/openy/virtual-ymca/gc-auth-settings)Check the "Require Email verification" on the "EMAIL VERIFICATION" settings for the Custom provider (/admin/openy/virtual-ymca/gc-auth-settings/provider/custom)
Create some user(s) on the /admin/people page, give the Virtual Y role(s)
Try to log in with the created user's email -- you should get the verification message
Verify the user -- clicking the link from an email, sent to the user's mail (visit the MailHog on http://mail.{pr_build_domain} and find the appropriate message)
(Ensure the
Drupal_visitor_auth_custom_authorizedcookie was created)Log out and try to log in with sane user's email -- you should be able to get in without the verification this time
Then try to log in with the same email in another browser or even device -- you should be requested for the verification again. And after once verified -- you should be able to log in without the verification on both browsers or devices.
Quality checks:
Please check these boxes to confirm this PR covers the following cases:
team in Slack