Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReClique SSO Integration in openy_gc_auth_reclique_sso module #254

Merged
merged 8 commits into from
Feb 1, 2021
Merged

ReClique SSO Integration in openy_gc_auth_reclique_sso module #254

merged 8 commits into from
Feb 1, 2021

Conversation

retif
Copy link

@retif retif commented Jan 28, 2021 •
edited
Loading

Related Issue/Ticket:

https://openy.atlassian.net/browse/PRODDEV-139

Steps to test:

  • Enable openy_gc_auth_reclique_sso module
  • Enter Reclique credentials at Reclique SSO OAuth2 provider settings
  • Enable Reclique SSO OAuth2 provider
  • Try to login at Virtual Y

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

@retif retif requested review from anpolimus and hamrant January 28, 2021 12:16
@retif retif self-assigned this Jan 28, 2021
@hamrant
Copy link

hamrant commented Jan 29, 2021

The current code looks ok for me.

@fivejars fivejars deleted a comment from fjbot Jan 29, 2021
@retif retif requested a review from NadyaRudenko January 29, 2021 12:16
@fivejars fivejars deleted a comment from fjbot Jan 29, 2021
anpolimus
anpolimus suggested changes Jan 29, 2021
View reviewed changes
Copy link

@anpolimus anpolimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better naming convention, lets rename it to openy_gc_auth_reclique_sso

@NadyaRudenko
Copy link

when you log out from Virtual Y, you remain logged in ReClique https://monosnap.com/file/V3g1spPqLyl8dwKkHifD3jnohVwPbu
@retif , @anpolimus

@retif
Copy link
Author

retif commented Jan 29, 2021

when you log out from Virtual Y, you remain logged in ReClique https://monosnap.com/file/V3g1spPqLyl8dwKkHifD3jnohVwPbu
@retif , @anpolimus

I think that is okay

@anpolimus
Copy link

@NadyaRudenko Oleks is right.
In the scope of this task, log out from CRM is not included.

NadyaRudenko
NadyaRudenko previously approved these changes Jan 29, 2021
View reviewed changes
@retif retif changed the title ReClique SSO Integration in openy_gc_auth_reclique_oauth2 module ReClique SSO Integration in openy_gc_auth_reclique_sso module Jan 29, 2021
@fivejars fivejars deleted a comment from fjbot Jan 29, 2021
@fivejars fivejars deleted a comment from fjbot Jan 29, 2021
@fivejars fivejars deleted a comment from fjbot Jan 29, 2021
@fivejars fivejars deleted a comment from fjbot Jan 30, 2021
@fjbot
Copy link

fjbot commented Jan 30, 2021

Build 2570

Find the builds:
http://pr-254.openy-gated-content.sandbox-2.ci.fivejars.com
http://rose.pr-254.openy-gated-content.sandbox-2.ci.fivejars.com
http://lily.pr-254.openy-gated-content.sandbox-2.ci.fivejars.com
http://carnation.pr-254.openy-gated-content.sandbox-2.ci.fivejars.com
http://upgrade.pr-254.openy-gated-content.sandbox-2.ci.fivejars.com

@anpolimus
Copy link

Code is ok.
Tested at build - everything is working properly.

@anpolimus anpolimus merged commit 7188abb into fivejars:master Feb 1, 2021
@TomScarboroughYMCA
Copy link

@NadyaRudenko - is there a way I can securely get a hold of the Client Id and Client Secret needed to test against the Open Y team's staging account with ReClique?

@NadyaRudenko
Copy link

@anpolimus, please advise ^^^ thanks!

@TomScarboroughYMCA
Copy link

@anpolimus and @NadyaRudenko - I was able to acquire some test credentials and do my testing, so I'm all-good on that. Hopefully you will see this so you will not get distracted getting me additional test users. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anpolimus anpolimus anpolimus approved these changes

@NadyaRudenko NadyaRudenko NadyaRudenko left review comments

@hamrant hamrant Awaiting requested review from hamrant

Assignees

@retif retif

Labels
IXM REVIEWED TESTED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@retif @hamrant @NadyaRudenko @anpolimus @fjbot @TomScarboroughYMCA