You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 19, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the problems described below tests were rewrote to Playwright. The creation of Dockerfile and docker-compose.yml is aimed to help in future debugging problems inside CI docker.
Problem with putting the integration tests inside docker:
It happens that libnice does not want to cooperate when it is being put inside docker, no matter if it is docker or host network. The results are unpredictable, when the first peer joins then he will get connected successfully but when the second peer joins then the libnice gets stuck in CONNECTING state (just for the first peer, the second one can see the first one without any problems).
The whole problem happens when the first peer is in a READY state and ice restart gets triggered. It automatically gets into CONNECTING state awaiting a new nominated ICE pair but none gets nominated therefore the agent is stuck in CONNECTING state forever. This is unpredictable but sometimes happens to work, this situation does not happen when developing locally without docker. Due to such thing happening it does not make any sense to put integration tests inside docker as it will fail most of the time.
The problem may be connected with lower resources available docker compared to those of an operating system when using locally, probably happened before on a weaker macbook without docker.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rados13
force-pushed
the
integration-tests
branch
from
Integration tests with the use of Playwright
Because of the problems described below tests were rewrote to Playwright. The creation of
Dockerfileanddocker-compose.ymlis aimed to help in future debugging problems inside CI docker.closes #5
Old issue about tests with the use of Wallaby
Problem with putting the integration tests inside docker:
It happens that libnice does not want to cooperate when it is being put inside docker, no matter if it is docker or host network. The results are unpredictable, when the first peer joins then he will get connected successfully but when the second peer joins then the libnice gets stuck in CONNECTING state (just for the first peer, the second one can see the first one without any problems).
The whole problem happens when the first peer is in a READY state and ice restart gets triggered. It automatically gets into CONNECTING state awaiting a new nominated ICE pair but none gets nominated therefore the agent is stuck in CONNECTING state forever. This is unpredictable but sometimes happens to work, this situation does not happen when developing locally without docker. Due to such thing happening it does not make any sense to put integration tests inside docker as it will fail most of the time.
The problem may be connected with lower resources available docker compared to those of an operating system when using locally, probably happened before on a weaker macbook without docker.