Changed sessions initialization to setup_all

Author: Qizot

integration/test_videoroom/lib/test_videoroom_web/channels/room_channel.ex

@@ -41,4 +41,9 @@ defmodule TestVideoroomWeb.RoomChannel do
 
     {:noreply, socket}
   end
+
+  @impl true
+  def handle_info({:DOWN, _ref, :process, room, :normal}, %{assigns: %{room: room}} = state) do
+    {:stop, :normal, state}
+  end
 end

integration/test_videoroom/test/integration/client_test.exs

@@ -75,29 +75,57 @@ defmodule TestVideoroom.Integration.ClientTest do
   @data Query.css("#data")
 
   setup_all do
-    {:ok, _pid} = TestVideoroom.Room.start(name: @room_name)
 
-    :ok
+    # start 3 chrome and 3 firefox sessions for each test to
+    # avoid high initialization time for each test
+    sessions =
+      1..3
+      |> Enum.flat_map(fn _ ->
+        [{:firefox, @firefox_capabilities}, {:chrome, @chrome_capabilities}]
+      end)
+      |> Enum.map(fn {browser, capabilities} ->
+        {:ok, session} = Wallaby.start_session(capabilities)
+
+        {browser, session}
+      end)
+      |> Enum.group_by(& elem(&1, 0), & elem(&1, 1))
+
+
+    on_exit(fn ->
+      Map.values(sessions) |> List.flatten() |> Enum.each(& Wallaby.end_session(&1))
+    end)
+
+    {:ok, browser_sessions: sessions}
+  end
+
+  def sessions_for_browser(%{browser_sessions: sessions}, browser, n) when n <= 3 and browser in [:chrome, :firefox] do
+    Enum.take(sessions[browser], n)
   end
 
-  setup do
+  setup ctx do
+    {:ok, _pid} = TestVideoroom.Room.start(name: @room_name)
     TestVideoroom.Room.register_new_peer_listener(@room_name, self())
+
+    on_exit(fn ->
+      :ok = GenServer.stop(:global.whereis_name("room"))
+
+      ctx.browser_sessions
+      |> Map.values()
+      |> List.flatten()
+      |> Enum.each(fn session ->
+        visit(session, @page)
+      end)
+
+    end)
   end
 
   @join_interval 5_000
   @leave_interval 5_000
 
-  # run 3 sessions for chrome and 2 for firefox
-  @sessions [
-    @firefox_capabilities,
-    @firefox_capabilities,
-    @chrome_capabilities,
-    @chrome_capabilities,
-    @chrome_capabilities
-  ]
   @moduletag timeout: 180_000
-  feature "Users gradually joining and leaving can hear and see each other", %{sessions: sessions} do
-    user_entries = prepare_users(sessions)
+  @sessions 0
+  feature "Users gradually joining and leaving can hear and see each other", ctx do
+    user_entries = prepare_users(sessions_for_browser(ctx, :chrome, 3) ++ sessions_for_browser(ctx, :firefox, 2))
 
     # assert that users can see each other when others are gradually joining
     user_entries =
@@ -153,24 +181,18 @@ defmodule TestVideoroom.Integration.ClientTest do
     assert :global.whereis_name("room") |> Process.alive?()
   end
 
-  @sessions [
-    @chrome_capabilities,
-    @chrome_capabilities,
-    @chrome_capabilities,
-    @firefox_capabilities,
-    @firefox_capabilities
-  ]
   @moduletag timeout: 180_000
-  feature "Users joining all at once can hear and see each other", %{sessions: sessions} do
-    user_entries = prepare_users(sessions)
+  @sessions 0
+  feature "Users joining all at once can hear and see each other", ctx do
+    user_entries = prepare_users(sessions_for_browser(ctx, :chrome, 3) ++ sessions_for_browser(ctx, :firefox, 3))
 
     # make all the users join the room
     for {user, _version} <- user_entries do
       join_room(user)
     end
 
     # wait for everybody to load
-    wait(10_000)
+    wait(15_000)
 
     total_users = length(user_entries)
 
@@ -189,16 +211,10 @@ defmodule TestVideoroom.Integration.ClientTest do
     assert :global.whereis_name("room") |> Process.alive?()
   end
 
-  @sessions [
-    @chrome_capabilities,
-    @chrome_capabilities,
-    @firefox_capabilities,
-    @firefox_capabilities
-  ]
   @moduletag timeout: 180_000
-  feature "Users joining without either microphone, camera or both can see or hear other users",
-          %{sessions: sessions} do
-    user_entries = prepare_users(sessions)
+  @sessions 0
+  feature "Users joining without either microphone, camera or both can see or hear other users", ctx do
+    user_entries = prepare_users(sessions_for_browser(ctx, :chrome, 2) ++ sessions_for_browser(ctx, :firefox, 2))
 
     # join all users
     user_entries
@@ -274,6 +290,11 @@ defmodule TestVideoroom.Integration.ClientTest do
     # can see the user with camera only
     assert Enum.any?(stats, &is_stream_playing(&1, %{audio: false, video: true}))
 
+
+    Enum.each(user_entries, fn {user, _version} ->
+      leave_room(user)
+    end)
+
     # make sure that the room is still alive
     assert :global.whereis_name("room") |> Process.alive?()
   end
@@ -323,7 +344,7 @@ defmodule TestVideoroom.Integration.ClientTest do
 
     for stream <- streams do
       assert is_stream_playing(stream),
-             "Session [#{inspect(session.capabilities.browserName)} -> #{inspect(session.id)}] expected a stream to be playing"
+             "Session [#{inspect(session.capabilities.browserName)} -> #{inspect(session.id)}] expected a stream to be playing, got #{inspect stream}"
     end
 
     {:ok, new_expected_data_version}