Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

[ML-311] Integrate Live Audio Mixer #278

Merged
merged 12 commits into from
Jun 16, 2023
Merged

Conversation

LVala
Copy link
Contributor

@LVala LVala commented Jun 5, 2023

No description provided.

@LVala LVala self-assigned this Jun 5, 2023
@LVala LVala force-pushed the integrate-live-audio-mixer branch from 8177ffd to ba50699 Compare June 6, 2023 11:26
@LVala LVala requested a review from Karolk99 June 6, 2023 11:36
@LVala LVala marked this pull request as ready for review June 7, 2023 11:30
@LVala LVala requested a review from mickel8 as a code owner June 7, 2023 11:30
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #278 (55fb602) into master (189afc1) will increase coverage by 0.57%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   62.38%   62.95%   +0.57%     
==========================================
  Files          43       44       +1     
  Lines        2092     2127      +35     
==========================================
+ Hits         1305     1339      +34     
- Misses        787      788       +1     
Impacted Files Coverage Δ
lib/membrane_rtc_engine/endpoints/hls_endpoint.ex 79.37% <65.00%> (+2.55%) ⬆️
test/support/hls_storage.ex 88.46% <88.46%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189afc1...55fb602. Read the comment docs.

Copy link
Contributor

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving to @Karolk99

Copy link
Contributor

@Karolk99 Karolk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove persist? option as we don't have a use case for it. We should always have it set to true.

@LVala LVala requested a review from Karolk99 June 12, 2023 13:21
@LVala LVala force-pushed the integrate-live-audio-mixer branch from 8c89112 to d0f9308 Compare June 13, 2023 11:12
@LVala
Copy link
Contributor Author

LVala commented Jun 13, 2023

The excluded tests will be fixed as a part of another task (tests in general are going to be revisited/rewritten) as we established.

@LVala LVala requested a review from Karolk99 June 13, 2023 11:18
Copy link
Contributor

@Karolk99 Karolk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is alright but we have to wait for new tests before merging to master.

@LVala LVala requested a review from Karolk99 June 16, 2023 10:35
@Karolk99 Karolk99 requested a review from mickel8 June 16, 2023 10:37
@LVala LVala merged commit 9d1b113 into master Jun 16, 2023
@LVala LVala deleted the integrate-live-audio-mixer branch June 16, 2023 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants