-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
8177ffd
to
ba50699
Compare
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 62.38% 62.95% +0.57%
==========================================
Files 43 44 +1
Lines 2092 2127 +35
==========================================
+ Hits 1305 1339 +34
- Misses 787 788 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving to @Karolk99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove persist?
option as we don't have a use case for it. We should always have it set to true.
lib/membrane_rtc_engine/endpoints/hls/config/sink_bin_config.ex
Outdated
Show resolved
Hide resolved
8c89112
to
d0f9308
Compare
The excluded tests will be fixed as a part of another task (tests in general are going to be revisited/rewritten) as we established. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is alright but we have to wait for new tests before merging to master.
No description provided.