Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

Refactor hls tests #281

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Refactor hls tests #281

merged 2 commits into from
Jun 16, 2023

Conversation

Karolk99
Copy link
Contributor

No description provided.

@Karolk99 Karolk99 requested a review from Rados13 June 16, 2023 07:52
@Karolk99 Karolk99 requested a review from mickel8 as a code owner June 16, 2023 07:52
@Karolk99 Karolk99 changed the base branch from master to integrate-live-audio-mixer June 16, 2023 07:53
@Karolk99 Karolk99 removed the request for review from mickel8 June 16, 2023 07:53
Comment on lines 64 to 66
assert_receive({:playlist_playable, :video, ^output_dir}, 10_000)
assert_receive({:segment, "video_segment_1" <> _}, 15_000)
assert_receive({:manifest, %{video_segments: 2}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be put into the function and then call it in all tests.

 defp assert_track(type) do 
      assert_receive({:playlist_playable, :"#{type}", ^output_dir}, 10_000)
      assert_receive({:segment, "#{type}_segment_1" <> _}, 15_000)
      assert_receive({:manifest, %{"#{type}_segments": 2}})
 end

Comment on lines 447 to 448
Enum.find(manifest_files, nil, &String.match?(&1, ~r/^(?!index).*$/))
|> then(&Path.join(output_dir, &1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enum.find(manifest_files, nil, &String.match?(&1, ~r/^(?!index).*$/))
|> then(&Path.join(output_dir, &1))
manifest_files
|> Enum.find(nil, &String.match?(&1, ~r/^(?!index).*$/))
|> then(&Path.join(output_dir, &1))

Copy link
Contributor

@Rados13 Rados13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, lint and tests fail.

@Karolk99 Karolk99 requested a review from Rados13 June 16, 2023 09:26
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #281 (64f05ae) into integrate-live-audio-mixer (d0f9308) will increase coverage by 4.45%.
The diff coverage is 88.46%.

@@                      Coverage Diff                       @@
##           integrate-live-audio-mixer     #281      +/-   ##
==============================================================
+ Coverage                       58.44%   62.90%   +4.45%     
==============================================================
  Files                              43       44       +1     
  Lines                            2101     2127      +26     
==============================================================
+ Hits                             1228     1338     +110     
+ Misses                            873      789      -84     
Impacted Files Coverage Δ
test/support/hls_storage.ex 88.46% <88.46%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f9308...64f05ae. Read the comment docs.

@Karolk99 Karolk99 merged commit 55fb602 into integrate-live-audio-mixer Jun 16, 2023
@Karolk99 Karolk99 deleted the refactor-hls-tests branch June 16, 2023 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants