Check for diversifier overflow #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
approved these changes
Dec 2, 2023
AaronFeickert
force-pushed
the
diversifier-overflow
branch
from
bc16a9f
to
4fbe758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Checks for overflow during diversifier decryption.
Closes #1370.
Code changes brief
When a diversifier is decrypted, it is truncated if its length exceeds
uint64_tbounds. This would only occur due to a malicious sender and should be rejected.This PR checks the decrypted diversifier length. If it does not precisely match that of an encoded
uint64_t, it throws an error.