Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark diversifiers can be truncated if invalid #1370

Closed
AaronFeickert opened this issue Dec 1, 2023 · 0 comments · Fixed by #1371
Closed

Spark diversifiers can be truncated if invalid #1370

AaronFeickert opened this issue Dec 1, 2023 · 0 comments · Fixed by #1371

Comments

@AaronFeickert
Copy link
Contributor

When diversifiers in Spark are decrypted, the plaintext data is truncated to fit a uint64_t. However, an adversary could have encrypted a value exceeding this (but not exceeding the AES block size), in which case any higher bits are discarded.

This should be modified. If the decrypted diversifier does not represent a valid 64-bit unsigned integer, it should be rejected as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant