Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear trace metadata from logs not used by GCP plugin. #1118

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

bryanatkinson
Copy link
Contributor

For logs written during span export in the GCP plugin, these default Otel trace fields are incorrect because the log is being written at a different time than during span execution.

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Docs updated

@bryanatkinson bryanatkinson force-pushed the bryanatkinson-log-trace-info-dup branch from 503bb71 to 0c66ea3 Compare October 24, 2024 18:44
@bryanatkinson bryanatkinson merged commit 0cf0740 into next Oct 28, 2024
4 checks passed
@bryanatkinson bryanatkinson deleted the bryanatkinson-log-trace-info-dup branch October 28, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants