Skip to content

Commit

Permalink
Clear trace metadata from logs not used by GCP plugin. (#1118)
Browse files Browse the repository at this point in the history
  • Loading branch information
bryanatkinson authored Oct 28, 2024
1 parent 64cd023 commit 0cf0740
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions js/plugins/google-cloud/src/gcpOpenTelemetry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,15 @@ export class GcpOpenTelemetry {
`projects/${projectId}/traces/${spanContext.traceId}`;
record['logging.googleapis.com/trace_sampled'] ??= isSampled ? '1' : '0';
record['logging.googleapis.com/spanId'] ??= spanContext.spanId;

// Clear out the duplicate trace and span information in the log metadata.
// These will be incorrect for logs written during span export time since
// the logs are written after the span has fully executed. Those logs are
// explicitly tied to the correct span in createCommonLogAttributes in
// utils.ts.
delete record['span_id'];
delete record['trace_id'];
delete record['trace_flags'];
};

async getConfig(): Promise<Partial<NodeSDKConfiguration>> {
Expand Down

0 comments on commit 0cf0740

Please sign in to comment.