Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Analytics Parameters of Lists #1126

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add support for Analytics Parameters of Lists #1126

merged 1 commit into from
Oct 21, 2024

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Adds support for Analytics Parameters to take in Dictionaries and Lists of Dictionaries, which is needed for some Analytics events like ViewCart.

Most of the logic is in C++ here:
firebase/firebase-cpp-sdk#1660

This has been a long missing feature, recently tracked via:
#1056

Testing

Describe how you've tested these changes.

Running locally

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from jonsimantov October 17, 2024 23:02
@a-maurice a-maurice merged commit c8fde34 into main Oct 21, 2024
26 of 27 checks passed
@a-maurice a-maurice deleted the am-analytics_parameter_lists branch October 21, 2024 21:35
@firebase firebase locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @jonsimantov