Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialize/deserialize stream token #3255

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Don't serialize/deserialize stream token #3255

merged 1 commit into from
Jun 24, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 23, 2020 •
edited
Loading

We don't need to roundtrip the stream token through our Base64 serializer.

Note: This is not the fix to the RN breakage. We are adding full base64 support in #3251

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 23, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (58e1b6f) Head (6b1a915) Diff
    browser 249 kB 249 kB -64 B (-0.0%)
    esm2017 194 kB 194 kB -67 B (-0.0%)
    main 492 kB 492 kB -181 B (-0.0%)
    module 246 kB 246 kB -64 B (-0.0%)

  • @firebase/firestore/memory

    Type Base (58e1b6f) Head (6b1a915) Diff
    browser 186 kB 186 kB -64 B (-0.0%)
    esm2017 145 kB 145 kB -67 B (-0.0%)
    main 362 kB 362 kB -181 B (-0.0%)
    module 184 kB 184 kB -64 B (-0.0%)

  • firebase

    Type Base (58e1b6f) Head (6b1a915) Diff
    firebase-firestore.js 287 kB 287 kB -79 B (-0.0%)
    firebase-firestore.memory.js 226 kB 226 kB -79 B (-0.0%)
    firebase.js 820 kB 820 kB -79 B (-0.0%)

Test Logs

wilhuff
wilhuff approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Keep this on your list of things we'll need to revert if we ever want to go back to persisting stream tokens :-).

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Jun 24, 2020
@schmidt-sebastian schmidt-sebastian merged commit b27974a into master Jun 24, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/removeroundtrip branch July 9, 2020 17:45
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wilhuff