-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReactNative build back, fix base64 serialization #3251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
June 22, 2020 19:26
schmidt-sebastian
force-pushed
the
mrschmidt/bringbackrn
branch
2 times, most recently
from
June 22, 2020 19:56
bb15184
to
ce6465e
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/bringbackrn
branch
from
June 22, 2020 20:01
ce6465e
to
163fc2a
Compare
Binary Size ReportAffected SDKs
Test Logs
|
schmidt-sebastian
changed the title
Mrschmidt/bringbackrn
Add ReactNative build back, fix base64 serializer
Jun 22, 2020
schmidt-sebastian
changed the title
Add ReactNative build back, fix base64 serializer
Add ReactNative build back, fix base64 serialization
Jun 22, 2020
We should fix the ESM 2017 build before proceeding with this change (Done) |
@Feiyang1 Do you have time to look at this? |
🦋 Changeset is good to goLatest commit: f64a733 We got this. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
requested review from
alikn,
andirayo and
avolkovi
as code owners
June 30, 2020 17:07
schmidt-sebastian
requested review from
egilmorez,
erikeldridge,
sam-gc,
scottcrossen,
yuchenshi,
zijianjoy and
zwu52
as code owners
June 30, 2020 17:07
Feiyang1
approved these changes
Jun 30, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested on iOS:
Fixes: #2667