Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReactNative build back, fix base64 serialization #3251

Merged
merged 9 commits into from
Jun 30, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 22, 2020

Manually tested on iOS:

  • Mutation can be written
  • Document listeners work
  • A Firestore Blob that is written in RN can be read from the native iOS SDK and contains the same value

Fixes: #2667

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 22, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (f54abc2) Head (122f72c) Diff
    browser 248 kB 248 kB +78 B (+0.0%)
    esm2017 194 kB 194 kB +78 B (+0.0%)
    module 246 kB 246 kB +78 B (+0.0%)
    react-native ? 194 kB ? (?)
  • @firebase/firestore/memory

    Type Base (f54abc2) Head (122f72c) Diff
    browser 186 kB 186 kB +108 B (+0.1%)
    esm2017 145 kB 145 kB +108 B (+0.1%)
    module 184 kB 184 kB +108 B (+0.1%)
    react-native ? 145 kB ? (?)
  • firebase

    Type Base (f54abc2) Head (122f72c) Diff
    firebase-firestore.js 286 kB 287 kB +78 B (+0.0%)
    firebase-firestore.memory.js 226 kB 226 kB +108 B (+0.0%)
    firebase.js 820 kB 820 kB +78 B (+0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian changed the title Mrschmidt/bringbackrn Add ReactNative build back, fix base64 serializer Jun 22, 2020
@schmidt-sebastian schmidt-sebastian changed the title Add ReactNative build back, fix base64 serializer Add ReactNative build back, fix base64 serialization Jun 22, 2020
@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Jun 23, 2020

We should fix the ESM 2017 build before proceeding with this change (Done)

@schmidt-sebastian
Copy link
Contributor Author

@Feiyang1 Do you have time to look at this?

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2020

🦋 Changeset is good to go

Latest commit: f64a733

We got this.

This PR includes changesets to release 9 packages
Name Type
firebase Minor
@firebase/firestore Minor
rxfire Major
@firebase/testing Patch
firebase-browserify-test Patch
firebase-package-typings-test Patch
firebase-messaging-selenium-test Patch
firebase-typescript-test Patch
firebase-webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian schmidt-sebastian merged commit 877c060 into master Jun 30, 2020
@github-actions github-actions bot mentioned this pull request Jul 6, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/bringbackrn branch July 9, 2020 17:44
@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.9.1 prevent the use of firestore in React Native
3 participants