Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce disk space usage when packaging the built SDK #763

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Reduce disk space usage when packaging the built SDK #763

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca93e79
Add a step to update vcpkg at build.
jonsimantov Nov 29, 2021
7a2b4e7
Remove intermediate build files to save space.
jonsimantov Nov 29, 2021
4aa531d
What is Python?
jonsimantov Nov 29, 2021
94e8c5e
Remove extraneous changes from another fix
jonsimantov Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/cpp-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,8 @@ jobs:
run: |
cd out-sdk
find .. -type f -print > src_file_list.txt
# Remove intermediate build files (.o and .obj) files to save space.
find . -type f -name '*.o' -or -name '*.obj' -print0 | xargs -0 rm -f --
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment: Would it make sense to run df before and after this command so you could quantify how much disk space was actually saved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that probably would have been a good idea. :)

tar -czhf ../firebase-cpp-sdk-${{ env.SDK_NAME }}-build.tgz .

- name: Print built libraries
Expand Down