-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add trenitalia #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add trenitalia #283
Conversation
Signed-off-by: lennartrommeiss <61516567+lenderom@users.noreply.github.com>
❌ Deploy Preview for fipguide failed.
|
Signed-off-by: lennartrommeiss <61516567+lenderom@users.noreply.github.com>
Thank you very much, that looks like a lot of work and there are quite a few exceptions to the rules when using FIP :o I sometimes found it difficult to follow the rules mentally, but that's probably due to the rules themselves rather than the wording. Perhaps we can find an optimized display of the images; they were displayed quite large on my Mac. |
@therobrob Thank you for your feedback. Are the images now looking better on your device? I also fixed #279 |
Hmm sadly on mobile devices the pictures are pretty small... But I created an issue where we can address this |
<!-- | ||
Ein kurzer zusammenfassender Text, der folgende Fragen in dieser Reihenfolge beantworten sollte: | ||
- Welche FIP Fahrtkarten (FIP 50/FIP Freifahrtsscheine) werden im Land anerkannt und bei welchen Bahngesellschaften? | ||
- Welche FIP Fahrtkarten (FIP 50/FIP Freifahrtscheine) werden im Land anerkannt und bei welchen Bahngesellschaften? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check this shortly before merging again to check if something got to Main meanwhile
#279
Der variable Reservierungspreis enthält immer einen Aufschlag bei Nutzung mit FIP Freifahrtschein. | ||
{{% /expander %}} | ||
|
||
{{% expander "FrecceLink (FL) ⛔" traincategory "le frecce" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{% expander "FrecceLink (FL) ⛔" traincategory "le frecce" %}} | |
{{% expander "FrecciaLink (FL) ⛔" traincategory "le frecce" %}} |
Der variable Reservierungspreis enthält immer einen Aufschlag bei Nutzung mit FIP Freifahrtschein. | ||
{{% /expander %}} | ||
|
||
{{% expander "FrecceLink (FL) ⛔" traincategory "le frecce" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we want list bus services under "Tarifliche Besonderheiten". At least that's what I did for regional bus services, do we handle long-distance bus services separately?
**Beschreibung:** \ | ||
Internationale Nachtzüge nach Deutschland, Österreich und in die Schweiz. | ||
|
||
⚠️ Nationale Freifahrten für Mitarbeitende der Deutschen Bahn werden in Deutschland nicht anerkannt. Liegt ein Teil der Nightjet Fahrt also in Deutschland (Start, Ende oder Durchreise) müssen Mitarbeitende der Deutschen Bahn für die gesamte Strecke ein Ticket zum FIP Globalpreis erwerben. Für Fahrten außerhalb Deutschlands mit FIP Freifahrtschein ist eine Reservierung/Aufpreis erforderlich. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a general rule or does it only apply to Germany? If an Italian FIP Coupon is not accepted in the Nightjet in Italy, then we could change the text to always refer to the issuing country instead of Germany.
|
||
<!-- TODO: Replace with markdown image and find ways to customize width --> | ||
<img src="/en/operator/fs/ordinaria_2.webp" alt="FS Ordinaria Ticket" style="width: 60%; float: right; margin-left: 2rem; margin-bottom: 1rem"> | ||
Der Bemerkung "non prenotabile" in den Zuginformationen: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Der expander heißt "Erkennung von zuggebundenen Tickets", aber dennoch werden zunächst Erkennungsmerkmale für nicht zugebundene Züge gelistet. Im Optimalfall kommen die nach den zuggebunden Erkennungsmerkmalen und eine kurze Überschrift ist auch notwendig.
it seems we have a cat and mouse game between italy and france here ;) |
Description
Checklist
The content was modified in the following languages: