-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format RawBytes debug as hex string rather than array of decimals #883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is much more usable.
fc975d2
to
a7b83a0
Compare
I'm having trouble landing this due to:
My local environment
replicates this warning, but if I remove the import then build fails with My IDE (1.63) also requires the import. This may be related to the discussion in filecoin-project/builtin-actors#660, but I can't see how to straightforwardly apply the same technique here. @mriise can you help? |
yeah! its a pretty simple fix :) |
} | ||
} | ||
|
||
mod test { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mod test { | |
#[cfg(test)] | |
mod test { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🤦
a7b83a0
to
4dbe9df
Compare
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
+ Coverage 52.01% 52.08% +0.06%
==========================================
Files 124 124
Lines 10191 10218 +27
==========================================
+ Hits 5301 5322 +21
- Misses 4890 4896 +6
|
The derived representation of a list of decimals is very unhelpful when debugging, e.g. CBOR-encoded values. The hex string will at least be usable in an CBOR inspector, and I think usually not less useful for cases when the bytes are representing something else (tho since this is the CBOR library, that'll be uncommon).
FYI @ZenGround0 when debugging actors.