Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format IpldBlock debug as a hex string #1339

Closed
anorth opened this issue Dec 19, 2022 · 2 comments · Fixed by #1402
Closed

Format IpldBlock debug as a hex string #1339

anorth opened this issue Dec 19, 2022 · 2 comments · Fixed by #1402
Assignees
@mriise
Milestone
M2.1 (r12) Carbon...

Comments

@anorth
Copy link
Member

anorth commented Dec 19, 2022

The introduction of IpldBlock for message parameters has regressed the debuggability improvements of #883. Please implement Debug for it to be easier to inspect.
@Stebalien
Copy link
Member

Ideally the alternative ({:#?}) implementation would decode the cbor... But maybe later.

@maciejwitowski
Copy link
Contributor

@arajasek a quick fix for this week?

@maciejwitowski maciejwitowski added this to the M2.1 (rr11) Carbonado.2 milestone Jan 2, 2023
@Stebalien Stebalien assigned mriise and unassigned arajasek Jan 4, 2023
@mriise mriise linked a pull request Jan 7, 2023 that will close this issue
Add custom Debug impl for IpldBlock formatting to use hex #1402
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mriise mriise

Labels
None yet
Projects
None yet
Milestone
M2.1 (r12) Carbonado.3
Development

Successfully merging a pull request may close this issue.

Add custom Debug impl for IpldBlock formatting to use hex filecoin-project/ref-fvm
5 participants
@Stebalien @anorth @arajasek @mriise @maciejwitowski