fix issue #127 #1155
Merged
fix issue #127 #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
commented
Jan 25, 2020
| @@ -269,6 +281,8 @@ type rpcFunc struct { | |||
|
|
|||
| hasCtx int | |||
| retCh bool | |||
|
|
|||
| retry bool | |||
There was a problem hiding this comment.
We save here if was tagged with retry.
| } | ||
|
|
||
| var defaultConfig = Config{ | ||
| ReconnectInterval: time.Second * 5, |
|
|
||
| type Option func(c *Config) | ||
|
|
||
| func WithReconnectInterval(d time.Duration) func(c *Config) { |
There was a problem hiding this comment.
If for some reason wants to change.
| if req.req.ID != nil { | ||
| if c.incomingErr != nil { // No conn?, immediate fail |
There was a problem hiding this comment.
Interestingly, whenever gorilla detects the connection is closed, it closes c.incoming. Didn't expect that but found it while making some tests. So we never assume after reading <-c.requests that we have a good conn. c.incomingErr is set again to nil when conn is reestablished (line 490)
magik6k
reviewed
Jan 25, 2020
Signed-off-by: jsign <jsign.uy@gmail.com>
|
Points addressed! |
Kubuxu
reviewed
Jan 26, 2020
Signed-off-by: jsign <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
This is a continuation of #1146, since the main idea of the other PR changed.
There's a new tag available
retry:"true".e.g"
It works the same if the return value is a chan or not.
The meaning is: the function call will not return with failure on a closed websocket channel. It will keep retrying while the connection is trying to be reestablished.
If the connection is closed before
sendRequest; saying it differently, the method is called with a closed connection:errof closed connectionIf the connection is closed after the request was sent, but before received reply (in-flight):
errWhen a connection is lost:
retry:"true"cases, they will continue retryingTested with
ChainHeadandChainNotifyand seems to work correctly.