Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsonrpc] High number of goroutines waiting for next message #1289

Closed
lanzafame opened this issue Feb 24, 2020 · 3 comments
Closed

[jsonrpc] High number of goroutines waiting for next message #1289

lanzafame opened this issue Feb 24, 2020 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lanzafame
Copy link
Contributor

Describe the bug
nextMessage appears to be leaking goroutines

To Reproduce
Steps to reproduce the behavior:

  1. Run miner for a while
  2. Run pprof trace

Expected behavior
There shouldn't be this many goroutines for nextMessage.

Screenshots
Screen Shot 2020-02-24 at 12 49 59

Version (run lotus --version):
master

@magik6k magik6k added bug good first issue Good for newcomers help wanted Extra attention is needed labels Feb 25, 2020
@magik6k
Copy link
Contributor

magik6k commented Feb 25, 2020

There are some fixes / changes to related code in #1221 (from #1155), so any investigating should happen on the testnet/3 branch, or after it's merged

@ridewindx
Copy link

Why jsonrpc?
jsonrpc just looks like a "deprecated" rpc mechanism convention which comes from btc/eth.
New blockchain should consider grpc, it's more mature and featured, also appropriate for public api.

@magik6k
Copy link
Contributor

magik6k commented Aug 31, 2020

Looks like this got fixed

@magik6k magik6k closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants