deps: Update to go-data-transfer v2 and libp2p #10382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
reviewed
Mar 3, 2023
MarcoPolo
reviewed
Mar 3, 2023
| @@ -52,37 +50,41 @@ func ResourceManager(connMgrHi uint) func(lc fx.Lifecycle, repo repo.LockedRepo) | |||
| // For every extra 1GB of memory we have available, increase our limit by 1GiB | |||
| defaultLimits.SystemLimitIncrease.Memory = 1 << 30 | |||
| defaultLimitConfig := defaultLimits.AutoScale() | |||
| if defaultLimitConfig.System.Memory > 4<<30 { | |||
|
|
|||
| changes := rcmgr.PartialLimitConfig{} | |||
There was a problem hiding this comment.
The diff in this file looks good to me for the rcmgr type changes. Sorry for the work, but hopefully it removes a foot gun.
hannahhoward
force-pushed
the
feat/go-data-transfer-v2
branch
from
4982bab to
7bc6185
Compare
| @@ -24,7 +24,7 @@ func TestPrintGroupInfo(t *testing.T) { | |||
| }) | |||
| chain, err := cg.FetchChainInfo(nil) | |||
| assert.NoError(t, err) | |||
| err = chain.ToJSON(os.Stdout) | |||
| err = chain.ToJSON(os.Stdout, nil) | |||
There was a problem hiding this comment.
Why use semver and then make breaking changes in a minor release? 🤬
marten-seemann
force-pushed
the
feat/go-data-transfer-v2
branch
from
ebb5de4 to
5b5ea08
Compare
magik6k
force-pushed
the
feat/go-data-transfer-v2
branch
from
d890349 to
d114d8f
Compare
marten-seemann
changed the title
marten-seemann
force-pushed
the
feat/go-data-transfer-v2
branch
from
f6d3ad7 to
0f5f91c
Compare
marten-seemann
force-pushed
the
feat/go-data-transfer-v2
branch
from
a7cdb5a to
4f060b8
Compare
marten-seemann
force-pushed
the
feat/go-data-transfer-v2
branch
2 times, most recently
from
c15bf98 to
1ebca7a
Compare
marten-seemann
force-pushed
the
feat/go-data-transfer-v2
branch
from
1ebca7a to
58306a8
Compare
magik6k
approved these changes
Mar 15, 2023
magik6k
force-pushed
the
feat/go-data-transfer-v2
branch
2 times, most recently
from
5a8247d to
7e414ac
Compare
magik6k
changed the title
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Update to the new version of go-data-transfer to unblock other deps updates
Status