Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails with golang version 1.20 #10278

Closed
8 of 18 tasks
f8-ptrk opened this issue Feb 15, 2023 · 3 comments
Closed
8 of 18 tasks

Compilation fails with golang version 1.20 #10278

f8-ptrk opened this issue Feb 15, 2023 · 3 comments
Labels
area/build Discussions about build and compilation issues

Comments

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Feb 15, 2023

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

lotus version 1.19.1-dev+hyperspacenet+git.392f1b815

Describe the Bug

# github.com/lucas-clemente/quic-go/internal/qtls
../../go/pkg/mod/github.com/lucas-clemente/quic-go@v0.29.1/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration

@ianconsolata

the GO_MIN_VERSION file is not enough - we need a max version too

Logging Information

not needed

Repo Steps

  1. Run '...'
  2. Do '...'
  3. See error '...'
    ...
@rjan90 rjan90 added area/build Discussions about build and compilation issues and removed kind/bug Kind: Bug need/triage labels Feb 21, 2023
@yorickdowne
Copy link

# github.com/lucas-clemente/quic-go/internal/qtls
/go/pkg/mod/github.com/lucas-clemente/quic-go@v0.29.1/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration

@rjan90
Copy link
Contributor

rjan90 commented Mar 16, 2023

Support for Golang version 1.20 and higher has been added with this PR: #10382, which will be included in the the Lotus v1.21.0 release.

@rjan90 rjan90 closed this as completed Mar 16, 2023
@johnnymatthews
Copy link

johnnymatthews commented Mar 29, 2023

Just tried to compile Lotus from the releases branch and got a similar error:

go: downloading github.com/marten-seemann/qtls-go1-19 v0.1.0
# github.com/lucas-clemente/quic-go/internal/qtls
../../go/pkg/mod/github.com/lucas-clemente/quic-go@v0.29.1/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration
make: *** [lotus] Error 1

I take it that #10382 didn't make it into the latest release?

Edit: never mind! This was only seen in v1.20.4. It'll be fixed in v1.21.0-rc1, and it'll be fixed in releases once that goes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Discussions about build and compilation issues
Projects
None yet
Development

No branches or pull requests

4 participants