Initial reconfiguration mechanism for Mir #234
Conversation
There was a problem hiding this comment.
Amazing job, @dnkolegov, @matejpavlovic. I left a few comments just for sanity-check and personal understanding, but I don't think there are any major blockers, feel free to merge if my comments don't rise any big issue. 🙏
|
@dnkolegov, do you mind looking at this before merging? We can look at it together if needed. Thanks 🙏 |
Co-authored-by: adlrocha <adlrocha@tutamail.com>
@adlrocha I ran tests 3 times via CI. No those data races so far. |
|
Beautiful, @dnkolegov Then it looks like its fixed. We need to handle the redundancy between the subnet lock and the manager lock, but I will add an issue and we can add it in a future PR. Let's wait for @matejpavlovic's on the networking race, and feel free to merge if it not a big issue. |
|
Sorry for the delay, responded to all comments now @dnkolegov and @adlrocha . |
|
Ok, this was a tough one, but I think after removing those TODOs we are ready to merge, @dnkolegov. Amazing job leading this one! 🙏 |
This PR introduces the Mir reconfiguration mechanism.
It also fixes #235