Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate multisig collector factory in a func #205

Merged

Conversation

matejpavlovic
Copy link
Contributor

Signed-off-by: Matej Pavlovic matopavlovic@gmail.com

@matejpavlovic
Copy link
Contributor Author

@dnkolegov if you adopt this approach in your Eudico integration, it will make the code much less ugly.
(Also resolves this: filecoin-project/eudico#234 (comment) )

@dnkolegov
Copy link
Contributor

@matejpavlovic Will do after merge

Copy link
Contributor

@xosmig xosmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
I left a couple of minor comments, but they can be addressed in later PRs.

Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants