define manifest data type for FIP 0031 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle and
anorth
as code owners
raulk
reviewed
Mar 24, 2022
FIPS/fip-0031.md
Outdated
Comment on lines
145
to
146
| The _Manifest_ data for version 1 (the only version currently defined) is a CID linking | ||
| to an IPLD `Vector<(String, CID)>`. |
There was a problem hiding this comment.
We should formally define the order of this vector.
There was a problem hiding this comment.
Here and, most importantly, in the system actor's state.
There was a problem hiding this comment.
So whats the order? By type? Lexicographic?
I dont think it really matters all that much, but i am not opposed ti specifying it either.
There was a problem hiding this comment.
So the bundler uses a BTreeMap, which orders by actor type -- this is perfectly reasonably I guess, should we make this the standard order?
There was a problem hiding this comment.
Updated to define the order by enum position.
raulk
approved these changes
Mar 31, 2022
kaitlin-beegle
pushed a commit
that referenced
this pull request
Apr 1, 2022
* fip-0031: prepare for move to Last Call. * define manifest data type for FIP 0031 (#329) Co-authored-by: raulk <raul@protocol.ai> Co-authored-by: vyzo <vyzo@hackzen.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.