fip-0031: prepare for move to Last Call. #328
Conversation
raulk
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle and
anorth
as code owners
raulk
force-pushed
the
raulk/finalize-fip-0031
branch
from
879dbc9 to
5142ead
Compare
| CodeCid = Cid(IPLD_RAW_CODEC, Mh(BLAKE2B-256, $wasm_bytecode)) | ||
| ``` | ||
|
|
||
| ### Sourcing built-in actors Wasm bytecode |
There was a problem hiding this comment.
@vyzo This FIP interests you, but specifically this part.
| CodeCid = Cid(IPLD_RAW_CODEC, Mh(BLAKE2B-256, $wasm_bytecode)) | ||
| ``` | ||
|
|
||
| ### Sourcing built-in actors Wasm bytecode |
There was a problem hiding this comment.
@vyzo This FIP interests you, but specifically this part.
|
Flagged @vyzo for review (see: Slack thread) per Raul's tags above. |
| content-addressing. The current _synthetic_ actor CodeCIDs will migrate to CIDs | ||
| that hash over their actual Wasm bytecode. | ||
| This FIP introduces no functional actor behaviour changes; however, some exit | ||
| codes have been adjusted. |
There was a problem hiding this comment.
Perhaps reference FIP-0032 as another change that is expected to be atomic with this one.
FIPS/fip-0031.md
Outdated
| https://github.com/filecoin-project/canonical-actors (TBD). | ||
| - The CARv1 header is single-rooted. | ||
| - The root CID resolves to a data structure that acts like a _Manifest_. | ||
| - The _Manifest_ type is an IPLD `Map<String, Cid>`. Every entry represents a |
There was a problem hiding this comment.
@Stebalien @vyzo Did we chance to a vector of tuples?
| | `fil/7/verifiedregistry` | TBD | | ||
| ```rust | ||
| struct State { | ||
| builtin_actor_registry: Cid, // Map<String, Cid> |
| ### Optional removal of intrinsic VM from Filecoin client codebases | ||
| #### VM atomic switch | ||
|
|
||
| Exactly at the upgrade epoch `N`, message execution will switch from the legacy |
There was a problem hiding this comment.
Could you specify "before" or "after" rather than "at"? There's been confusion in the past about when migrations happen (and we should follow the past behaviour)
|
|
||
| ## Implementation | ||
|
|
||
| WIP. | ||
| This FIP will be implemented in the reference Filecoin client implementation: |
There was a problem hiding this comment.
I think we have historically tried to avoid elevating any implementation as "reference". Even if it is de-facto, it's not a state we wish to prolong.
Co-authored-by: raulk <raul@protocol.ai>
|
@vyzo's PR is merged. This is ready to be merged too upon approval. |
This is a heavy editing pass that should get this FIP closer to Last Call. We're missing the final content-addressed Code CIDs, but these won't be available until later. And they are simple parameters that don't affect the body of the changes proposed in this FIP.