Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fides 0.7.2 #47

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Fides 0.7.2 #47

merged 5 commits into from
Nov 26, 2021

Conversation

FFroehlich
Copy link
Contributor

  • adds additional option value type validation
  • fixes runtime warning for unbounded problems
  • fixes optimization based stepback mode refined

dweindl and others added 5 commits November 22, 2021 18:08
@dweindl @FFroehlich
Verify options are of correct type (#45)
8544a92 
* Verify options are of correct type

Wasn't checked so far and led to very uninformative errors if wrong options were passed.

* Apply suggestions from code review

Co-authored-by: Fabian Fröhlich <fabian@schaluck.com>
@FFroehlich
fix runtime warning for unbouned vars, fixes #46
6f6e428
@FFroehlich
fixup
31b4f09
@FFroehlich
fix refined step
8279c4f
@FFroehlich
bump version
6fd09e5
@codecov
Copy link

codecov bot commented Nov 26, 2021 •
edited
Loading

Codecov Report

Merging #47 (6fd09e5) into master (db158b4) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   95.15%   95.01%   -0.15%     
==========================================
  Files          10       10              
  Lines         971      982      +11     
==========================================
+ Hits          924      933       +9     
- Misses         47       49       +2
Impacted Files Coverage Δ
fides/steps.py 97.22% <ø> (ø)
fides/minimize.py 93.68% <100.00%> (+0.19%) ⬆️
fides/trust_region.py 97.22% <100.00%> (ø)
fides/version.py 100.00% <100.00%> (ø)
fides/stepback.py 88.88% <0.00%> (-11.12%) ⬇️
fides/hessian_approximation.py 94.88% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db158b4...6fd09e5. Read the comment docs.

@FFroehlich FFroehlich merged commit 4a666b5 into master Nov 26, 2021
@FFroehlich FFroehlich deleted the release_0_7_2 branch November 26, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FFroehlich @dweindl