Verify options are of correct type #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't checked so far and led to very uninformative errors if wrong options were passed.
FFroehlich
approved these changes
Nov 22, 2021
FFroehlich
reviewed
Nov 22, 2021
FFroehlich
reviewed
Nov 22, 2021
|
👍 |
FFroehlich
added a commit
that referenced
this pull request
Nov 26, 2021
* Verify options are of correct type (#45) * Verify options are of correct type Wasn't checked so far and led to very uninformative errors if wrong options were passed. * Apply suggestions from code review Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> * fix runtime warning for unbouned vars, fixes #46 * fixup * fix refined step * bump version Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
FFroehlich
added a commit
that referenced
this pull request
Nov 27, 2021
* Verify options are of correct type (#45) * Verify options are of correct type Wasn't checked so far and led to very uninformative errors if wrong options were passed. * Apply suggestions from code review Co-authored-by: Fabian Fröhlich <fabian@schaluck.com> * fix runtime warning for unbouned vars, fixes #46 * fixup * fix refined step * move validation check, reenable passing strs for enums * fixup option validation, remove deprecated checks * Update version.py Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't checked so far and led to very uninformative errors if wrong options were passed.