Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(modules): update modules for spin v0.4.0 compatibility #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vdice
Copy link
Member

@vdice vdice commented Aug 29, 2022

Updates the bartholomew and spin_static_fs modules for compatibility with spin v0.4.0.

The bartholomew.wasm was built from the most recent v0.4.0 tag and spin_static_fs.wasm from HEAD.

Currently on HEAD, when we run npm run spin with a spin v0.4.0 client, we see:

$ npm run spin

> docs-website-template@0.1.0 spin
> nodemon --watch content --watch static --watch templates --ext md,rhai,hbs,css,js --verbose --legacy-watch --signal SIGINT --exec 'spin up --file spin.toml'

[nodemon] 2.0.15
[nodemon] to restart at any time, enter `rs`
[nodemon] or send SIGUSR2 to 40398 to restart
[nodemon] watching path(s): content/**/* static/**/* templates/**/*
[nodemon] watching extensions: md,rhai,hbs,css,js
[nodemon] starting `spin up --file spin.toml`
[nodemon] spawning
[nodemon] child pid: 40421
[nodemon] watching 33 files
Serving http://127.0.0.1:3000
Available Routes:
  bartholomew: http://127.0.0.1:3000 (wildcard)
  fileserver: http://127.0.0.1:3000/static (wildcard)
2022-08-29T17:43:43.135700Z ERROR spin_http_engine: Error processing request: invalid discriminant for `option

Note that updates will again be needed upon the next spin release, at least for bartholomew (fermyon/bartholomew#109).

Tested via npm run spin with spin spin 0.4.0 (784094e 2022-07-13).

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant