-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spin compatibility: remove wasi-experimental-http #109
Comments
Actually, I may have this wrong. I don't see Bartholomew using wasi-experimental-http directly, it is just in the Cargo.lock. Perhaps what is necessary is to bump the spin SDK version? |
I just tested it and the SDK version is not causing it. It is a dependency
|
Thanks for checking this out, @karthik2804. Interesting... would we lose functionality if we go with the v0.2.0 downgrade? |
i had been working on a branch to fix it. but don't have a fix for it right now. v0.3.0 was working fine with downgrading to v0.2.0 will lose tweets/gists embedding functionality. we can downgrade until we can fix it? |
It doesn't work because one of the latest commits to spin removed support for |
Yeah, we don't need to remove functionality — rather than using the bespoke |
I was able to get it working with spin sdk, but not able to publish new release as it needs a released version of spin-sdk. Is that something we can do @radu-matei ? I will spend more time on it tomorrow and will try to get a release pushed (worst case try to implement outbound http in handlebars sprig repo). Thank you everyone for the inputs. |
@rajatjindal can we not just switch from using a release of handlebars-sprig in Bartholomew to using a |
We can, i was just not sure of it will be acceptable. If the team is ok with that, i am happy to open pr for it. |
That definitely works, @rajatjindal! |
Spin removed support for wasi-experimental-http in fermyon/spin#699.
I believe Bartholomew needs to do the same for compatibility with Spin.
(To be clear, the last v0.4.0 release of Spin is compatible)
For instance, when I try to run the docs site with Spin built from HEAD, I see:
The text was updated successfully, but these errors were encountered: