-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ItemData instance creation from XML #37
Comments
Rather than creating an ambiguous "item" tag inside a class tag, it might be more productive to make another subclass - This is going to be confusing and stupid. Depending on how things go I may also make a subclass for the nested items, making the list info subclass |
On second thought, I was right. This was confusing and stupid. It is better to go with a recursive method of nesting ItemDatas instead of having different classes for items that might have items inside them. |
This will require extensive modifications to the CLI (or even just replacing it completely - see #36), but I essentially want the XML to be "inflated" similarly to a layout file, where the entire package name of each class is provided in the tag. Sub-tags, like "contributor" or "link" would be unaffected (or even replaced with an ambiguous name, like "item"), and would simply be passed to the constructor of each "main" item (or I could just continue passing an instance of the parser like I am now). This would allow users to add their own functionality to the about screen instead of only being able to override layout files.
The text was updated successfully, but these errors were encountered: