Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates.html: include satisfied requirements in the table #5388

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

AdamWill
Copy link
Contributor

I noticed today that tests which are 'required' aren't marked as such in the Bodhi webUI if they passed. Only queued or failed or missing tests are shown as 'required' (as shown by the black asterisk with a mouseover comment, on the Automated Tests tab). This is because we're not pushing satifised requirements into the list that's used to track which tests are required.

@AdamWill AdamWill requested a review from a team as a code owner June 23, 2023 07:25
@AdamWill
Copy link
Contributor Author

Note, this stuff is technically incorrect in another way: for greenwave requirements it does not consider the scenario, which it technically ought to. But in practice, I don't think we have any cases where a given testcase name is required in some scenarios but not others, so for now this will give the correct result. I don't want to fix it any harder for now because if we start making non-trivial changes to this stuff, we should think about #3938 first.

It would be nice for this requirements thing to be a Set not an array, but I guess we're trying to stick to the original data types only...

Note, it was probably me who broke this in the first place in one of my previous rearrangements of all this code, so sorry. :)

I noticed today that tests which are 'required' aren't marked
as such in the Bodhi webUI if they passed. Only queued or failed
or missing tests are shown as 'required' (as shown by the
black asterisk with a mouseover comment, on the Automated Tests
tab). This is because we're not pushing satifised requirements
into the list that's used to track which tests are required.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

end
@AdamWill AdamWill force-pushed the mark-satisfied-requirements branch from c817bfb to 725e1f9 Compare June 23, 2023 07:42
@AdamWill
Copy link
Contributor Author

Rawhide integration test failure is a CI issue - https://kojipkgs.fedoraproject.org/repos-dist/frawhide-infra/latest/x86_64/repodata/repomd.xml doesn't exist (not sure that frawhide is right).

@mattiaverga mattiaverga added the 7.2-backports Mergify uses this to backport patches to 7.2 label Jun 25, 2023
@mattiaverga
Copy link
Contributor

I've cherry-picked the change in bodhi.stg and, even if the db is still not updated, I think it's working as expected:
immagine

@mattiaverga
Copy link
Contributor

Rawhide integration test failure is a CI issue - https://kojipkgs.fedoraproject.org/repos-dist/frawhide-infra/latest/x86_64/repodata/repomd.xml doesn't exist (not sure that frawhide is right).

It's https://pagure.io/fedora-infra/ansible/raw/main/f/files/common/fedora-infra-tags.repo for some reason f$releasever-infra is no more parsed right in Rawhide

@mergify mergify bot merged commit 36cc800 into fedora-infra:develop Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.2-backports Mergify uses this to backport patches to 7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants